Skip to content

feat: Update storybook to 6.5.12 - #2506

Merged
Keith-CY merged 2 commits into
nervosnetwork:new-ui-designfrom
yanguoyu:feat-update-storybook
Oct 20, 2022
Merged

feat: Update storybook to 6.5.12#2506
Keith-CY merged 2 commits into
nervosnetwork:new-ui-designfrom
yanguoyu:feat-update-storybook

Conversation

@yanguoyu

Copy link
Copy Markdown
Contributor
  1. Add react-transition-group because primereact depend on it. We only use Calendar in primereact to develop DatetimePicker, I think we can remove primereact later, it's a too-big package. We don't need add react-transition-group before because @storybook/addon-knobs depend on it, and now we remove @storybook/addon-knobs.
  2. Add webpack devDependencies because storybook need explicitly specify webpack.

1. Add `react-transition-group` because `primereact` depend on it.
We only use Calendar in `primereact` to develop `DatetimePicker`, I think we can remove `primereact` later, it's a too big package.
2. Add `webpack` devDependencies because `storybook` need explicitly specify `webpack`.
Comment thread packages/neuron-ui/.storybook/.babelrc Outdated
Comment thread packages/neuron-ui/.storybook/electron.js Outdated
Comment thread packages/neuron-ui/.storybook/electron.js Outdated
@Cedar67

Cedar67 commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

@yanguoyu Does this pr affect functionality or user experience? If necessary, pls list specific functional impact points.

@yanguoyu

yanguoyu commented Oct 19, 2022

Copy link
Copy Markdown
Contributor Author

@yanguoyu Does this pr affect functionality or user experience? If necessary, pls list specific functional impact points.

Only the data picker component may be affected when sending ckb to other addresses.
Others will not be affected, if Neuron can be normally packaged and run, it will be ok.

@Cedar67

Cedar67 commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

@yanguoyu Does this pr affect functionality or user experience? If necessary, pls list specific functional impact points.

It will not affect functions, if Neuron can be normally packaged and run, it will be ok.

got it.

@Cedar67

Cedar67 commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

@yanguoyu The style of the button here is not affected by this change?

image

@yanguoyu

Copy link
Copy Markdown
Contributor Author

@yanguoyu The style of the button here is not affected by this change?

image

Of course, it was caused by new wallet with new UI.

@Cedar67 Cedar67 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified.

@Keith-CY
Keith-CY merged commit e06f872 into nervosnetwork:new-ui-design Oct 20, 2022
@yanguoyu
yanguoyu deleted the feat-update-storybook branch October 20, 2022 06:22
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Oct 23, 2022
yanguoyu added a commit that referenced this pull request Oct 23, 2022
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants