feat: use undici to replace axios - #2508
Merged
Merged
Conversation
1. change tsconfig because the index.js in axios is ESM. @zerollup/ts-transform-paths will change axios to ../../node_module/axios, it will require axios/index.js, then it will throw exception in Node.js with ESM.
Contributor
Author
|
This PR may affect |
yanguoyu
changed the title
yanguoyu
marked this pull request as ready for review
October 19, 2022 07:20
Contributor
|
Unit test error. |
Contributor
Author
Fixed |
Keith-CY
approved these changes
Oct 21, 2022
alexsupa597
approved these changes
Oct 21, 2022
Contributor
Both of these functions have been verified. |
Cedar67
approved these changes
Oct 21, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undiciis created by Node.js org. Using it in Node.js is better.