Skip to content

Feat: new UI nav menu - #2513

Merged
Keith-CY merged 3 commits into
nervosnetwork:new-ui-designfrom
yanguoyu:feat-new-ui-nav
Nov 1, 2022
Merged

Feat: new UI nav menu#2513
Keith-CY merged 3 commits into
nervosnetwork:new-ui-designfrom
yanguoyu:feat-new-ui-nav

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Oct 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

image

image

image

image

@yanguoyu yanguoyu mentioned this pull request Oct 25, 2022
Closed
3 tasks
@yanguoyu

yanguoyu commented Oct 25, 2022

Copy link
Copy Markdown
Contributor Author

I have a little query about the expansion menu, so expand menu does not finish yet.

@Cedar67

Cedar67 commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

The Chinese copy here needs to be confirmed or modified.

image

@Keith-CY

Keith-CY commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

The Chinese copy here needs to be confirmed or modified.

image

Pick 实验性/experimental which is used in the production version now.

@Cedar67

Cedar67 commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Pick 实验性/experimental which is used in the production version now.

ok. The Figma UI design Copy needs to be modified.

@Cedar67

Cedar67 commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

The current wallet name is abnormal when it is too long.

image

@Cedar67

Cedar67 commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

The font on the right of the image below is recommended.

image

@yanguoyu

yanguoyu commented Oct 26, 2022

Copy link
Copy Markdown
Contributor Author

The font on the right of the image below is recommended.

image

These fonts should be system default

@Cedar67

Cedar67 commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

These fonts should be system default

ok, just follow this rule.

Keith-CY
Keith-CY reviewed Oct 28, 2022
View reviewed changes
Comment thread packages/neuron-ui/src/components/Tooltip/index.tsx Outdated
Comment thread packages/neuron-ui/src/components/Tooltip/tooltip.module.scss Outdated
@yanguoyu
yanguoyu marked this pull request as draft October 28, 2022 06:17
@yanguoyu

yanguoyu commented Oct 28, 2022

Copy link
Copy Markdown
Contributor Author

The current wallet name is abnormal when it is too long.

image

Fixed and add expand menu.

@yanguoyu
yanguoyu marked this pull request as ready for review October 28, 2022 12:47
@yanguoyu
yanguoyu requested a review from Keith-CY October 28, 2022 12:47
@Cedar67

Cedar67 commented Nov 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

The current wallet name is abnormal when it is too long.
image

Fixed and add expand menu.

Verified.

image

image

Cedar67
Cedar67 approved these changes Nov 1, 2022
View reviewed changes

@Cedar67 Cedar67 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function and user experience are both verified.

@Keith-CY
Keith-CY merged commit 9435681 into nervosnetwork:new-ui-design Nov 1, 2022
@yanguoyu
yanguoyu deleted the feat-new-ui-nav branch November 2, 2022 01:11
@Keith-CY Keith-CY mentioned this pull request Feb 23, 2023
Closed
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 10, 2023
@yanguoyu
Feat: new UI nav menu (nervosnetwork#2513)
b92d453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@Keith-CY Keith-CY Keith-CY approved these changes
@alexsupa597 alexsupa597 alexsupa597 approved these changes
@Cedar67 Cedar67 Cedar67 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanguoyu @Cedar67 @Keith-CY @alexsupa597