feat: Update ckb node to 0.105.1

[yanguoyu]

1. migrate success

migrate-success.mov

2. migrate failed

migrate-failed.mov

[Keith-CY]

If migration fails, will data of ckb be broken?

I ask this because if I need to send a transaction immediately but migration fails, I would prefer to keep data there and use a previous version of Neuron to send the transaction, instead of removing all data and synchronizing from scratch.

If the data of ckb are still available after migration fails, a cancel/dismiss button can be added in the removing data dialog so users can keep the original data.

[yanguoyu]

If migration fails, will data of ckb be broken?

I ask this because if I need to send a transaction immediately but migration fails, I would prefer to keep data there and use a previous version of Neuron to send the transaction, instead of removing all data and synchronizing from scratch.

If the data of ckb are still available after migration fails, a cancel/dismiss button can be added in the removing data dialog so users can keep the original data.

If ckb migrate broken in progress, it can't run by old version like v0.104.1.

[Keith-CY]

If migration fails, will data of ckb be broken?
I ask this because if I need to send a transaction immediately but migration fails, I would prefer to keep data there and use a previous version of Neuron to send the transaction, instead of removing all data and synchronizing from scratch.
If the data of ckb are still available after migration fails, a cancel/dismiss button can be added in the removing data dialog so users can keep the original data.

If ckb migrate broken in progress, it can't run by old version like v0.104.1.

Then we should allow users not to migrate.

Maybe we can add a button next to the ok button that is labeled with Go to backup and the directory where ckb data is will be opened by it.

[yanguoyu]

I add a choice for users to choose to migrate or not by b9c8e3a

[Keith-CY]

I add a choice for users to choose to migrate or not by b9c8e3a

Style of cancel button should be consistent with other components

[yanguoyu]

Style of cancel button should be consistent with other components

It looks like this now:

[Cedar67]

When Clicking on the background window area behind the pop-up window, the pop-up window will automatically disappear.

Expected: the pop-up window will always appear unless the button is clicked.

Screen.Recording.2022-11-07.at.19.11.58.mov

[yanguoyu]

Expected: the pop-up window will always appear unless the button is clicked.

Fixed.

[Cedar67]

Expected: the pop-up window will always appear unless the button is clicked.

Fixed.

Verified.

[Cedar67]

When Neuron is restarted after clicking Migrate, no migration status is displayed.
Users may not know whether the migration is in progress or how to restart the migration.

Expected: When Neuron is restarted after clicking Migrate, the migration status is displayed.

[yanguoyu]

When Neuron is restarted after clicking Migrate, no migration status is displayed. Users may not know whether the migration is in progress or how to restart the migration.

Expected: When Neuron is restarted after clicking Migrate, the migration status is displayed.

Neuron can continue to migrate after reopening.

[Cedar67]

When Neuron is restarted after clicking Migrate, no migration status is displayed. Users may not know whether the migration is in progress or how to restart the migration.
Expected: When Neuron is restarted after clicking Migrate, the migration status is displayed.

Neuron can continue to migrate after reopening.

Verified: Neuron automatically continues the previous migration normally after restart.

[Cedar67]

The spelling of this word needs fixing?
Expected: migrate

[yanguoyu]

The spelling of this word needs fixing? Expected: migrate

Fixed.

[Cedar67]

There is one user experience optimization to consider:

In this scenario, Neuron has no pop-up to prompt the user to choose whether to migrate or not:

1. An old node Data A has been migrated.
2. Then, change the Data Settings to another old node Data B that has been migrated in the future.

Now:
The old data B is automatically migrated without a pop-up prompt to confirm.

Expected:
The pop-up prompt is displayed to determine whether to migrate the old data according to the user's choice.

[yanguoyu]

There is one user experience optimization to consider:

In this scenario, Neuron has no pop-up to prompt the user to choose whether to migrate or not:

1. An old node Data A has been migrated.
2. Then, change the Data Settings to another old node Data B that has been migrated in the future.

Now: The old data B is automatically migrated without a pop-up prompt to confirm.

Expected: The pop-up prompt is displayed to determine whether to migrate the old data according to the user's choice.

I think users only need to choose whether migrate once. Once they set the path to old data, they should know why this data is migrating.

[Cedar67]

The migration failure was prompted when I still had 6G of space on my local disk.
After clicking the "Confirm" button, the corresponding old Data would be automatically deleted.

Does the migration require any specific local disk space?

Expected:

1. In the migration confirmation dialog box, describe the disk space requirements.
2. When the migration is terminated abnormally, the cause of the failure is displayed.
3. It is recommended that users be provided with the option to retain old data and suspend migration. Instead of deleting the old data directly.

[Cedar67]

There is one user experience optimization to consider:
In this scenario, Neuron has no pop-up to prompt the user to choose whether to migrate or not:

1. An old node Data A has been migrated.
2. Then, change the Data Settings to another old node Data B that has been migrated in the future.

Now: The old data B is automatically migrated without a pop-up prompt to confirm.
Expected: The pop-up prompt is displayed to determine whether to migrate the old data according to the user's choice.

I think users only need to choose whether migrate once. Once they set the path to old data, they should know why this data is migrating.

Users may forget about previous migration actions, because the actual users may not care about its impact.
This is an optimization recommendation and has no blocking effect on functionality.

[Cedar67]

Indexer data was not cleared after Synchronize from scratch was selected.
This is a node data that has been migrated.

[Cedar67]

log error when switching to a Node data (This is a newly created node data.)

[yanguoyu]

The migration failure was prompted when I still had 6G of space on my local disk. After clicking the "Confirm" button, the corresponding old Data would be automatically deleted.

Does the migration require any specific local disk space?

@quake
Can we estimate the disks that need to keep in the migration process?

[yanguoyu]

Indexer data was not cleared after Synchronize from scratch was selected. This is a node data that has been migrated.

Removed tips about indexer.

[yanguoyu]

The migration failure was prompted when I still had 6G of space on my local disk. After clicking the "Confirm" button, the corresponding old Data would be automatically deleted.

Does the migration require any specific local disk space?

Expected:

1. In the migration confirmation dialog box, describe the disk space requirements.
2. When the migration is terminated abnormally, the cause of the failure is displayed.
3. It is recommended that users be provided with the option to retain old data and suspend migration. Instead of deleting the old data directly.

Add a cancel button for users to select, and show migrate failed message.

[yanguoyu]

log error when switching to a Node data (This is a newly created node data.)

This is a warning when getting a transaction by tx hash. But the 0x2d20948c890fe2c9dbcd0861332579c89c4020a24d8bf1fbd6e055ba904402d in your screenshot I haven't found the transaction hash on the mainnet or testnet. I don't where is from. Besides, it will not affect functions.
And you can also try clear cache to clear this warning.

[Cedar67]

The migration failure was prompted when I still had 6G of space on my local disk. After clicking the "Confirm" button, the corresponding old Data would be automatically deleted.

Does the migration require any specific local disk space?

Expected:

1. In the migration confirmation dialog box, describe the disk space requirements.
2. When the migration is terminated abnormally, the cause of the failure is displayed.
3. It is recommended that users be provided with the option to retain old data and suspend migration. Instead of deleting the old data directly.

Add conditional info: When this occurs, there is still 6 GB of PC disk space for Node data before starting the migration.

[Cedar67]

Indexer data was not cleared after Synchronize from scratch was selected. This is a node data that has been migrated.

Removed tips about indexer.

Verified.

[Cedar67]

The migration failure was prompted when I still had 6G of space on my local disk. After clicking the "Confirm" button, the corresponding old Data would be automatically deleted.
Does the migration require any specific local disk space?

Expected:

1. In the migration confirmation dialog box, describe the disk space requirements.
2. When the migration is terminated abnormally, the cause of the failure is displayed.
3. It is recommended that users be provided with the option to retain old data and suspend migration. Instead of deleting the old data directly.

Add a cancel button for users to select, and show migrate failed message.

1. The Cancel button and migrate failed message are both displayed now. This is an expected fixed.
2. At the end of the prompt, an extra curly bracket is displayed. Please confirm.
3. Updated the ckb node to v0.106.0-rc1, there were still unexplained disk space error messages. Please confirm.

[yanguoyu]

Updated the ckb node to v0.106.0-rc1, there were still unexplained disk space error messages. Please confirm.

You can download v0.106.0-rc1 ckb release file, and run migrate with the old data path. This can exclude Neuron effect.
Run like this ./ckb migrate -C old-path --force

[yanguoyu]

At the end of the prompt, an extra curly bracket is displayed. Please confirm.

This is because the error message includes a bracket at the end.

[Cedar67]

Updated the ckb node to v0.106.0-rc1, there were still unexplained disk space error messages. Please confirm.

You can download v0.106.0-rc1 ckb release file, and run migrate with the old data path. This can exclude Neuron effect. Run like this ./ckb migrate -C old-path --force

v0.106.0-rc1 ckb Runs cmd ./ckb migrate -C old-path --force complete without error.

[Cedar67]

The migration failure was prompted when I still had 6G of space on my local disk.

After upgrading to v0.106.0-rc2 of ckb, no disk space error was repeated during the migration.

Ref Magickbase/neuron-public-issues#55 (comment)