chore: bump react.js from 16 to 18 - #2519
Merged
Keith-CY merged 2 commits intoDec 7, 2022
Merged
Conversation
Contributor
|
bootstrap error. |
alexsupa597
marked this pull request as ready for review
November 10, 2022 16:31
yanguoyu
reviewed
Nov 11, 2022
Keith-CY
reviewed
Nov 11, 2022
Keith-CY
reviewed
Nov 14, 2022
1 task
Keith-CY
approved these changes
Nov 16, 2022
yanguoyu
approved these changes
Nov 16, 2022
Contributor
|
Conflicted |
Contributor
|
Verified on macOS, no exception found. |
added 2 commits
December 6, 2022 15:52
Contributor
|
Verified on Windows OS, no exception found now. |
Contributor
Verified on macOS, no exception found now. |
Cedar67
approved these changes
Dec 7, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Since React.js 16.8, there exists a few important changes, the latest version of react.js is v18.2.0. So it seems necessary for us to update our React version.
Updating the react version may involve a number of other dependencies that need to be upgraded simultaneously,
such as react-dom, react-script, node, typescript, etc. I'll update the version to 17 first, and then up to 18 if possible.
Ref: Magickbase/neuron-public-issues#73
Check List
Test
e2e Test
Task
none