feat: remove uifabric experiments and uifabric styling - #2537
Merged
Keith-CY merged 7 commits intoFeb 6, 2023
Merged
Conversation
alexsupa597
marked this pull request as draft
November 29, 2022 15:19
Keith-CY
reviewed
Dec 9, 2022
Keith-CY
changed the title
yanguoyu
reviewed
Dec 9, 2022
1 task
Contributor
|
How is it going |
added 4 commits
December 30, 2022 17:02
Keith-CY
reviewed
Jan 5, 2023
Keith-CY
approved these changes
Jan 18, 2023
Contributor
|
An error is reported when
|
Author
@Cedar67 Please try to use node v16.x in this branch. Thanks. |
1 task
yanguoyu
pushed a commit
to yanguoyu/neuron
that referenced
this pull request
Mar 10, 2023
alexsupa597
deleted the
chore/remove-uifabric-experiments-and-uifabric-styling
branch
April 26, 2023 07:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As title.
We optimized the component of
paginationfor our new design, based on the older one. And now it looks like this.Figma: https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=1864%3A13010&t=nQX1X5PDTzdGwPKo-0
Ref: Magickbase/neuron-public-issues#68
Check List
Test
e2e Test
Task
none