Skip to content

Chore: call rimraf with npx - #2543

Merged
Keith-CY merged 1 commit into
nervosnetwork:developfrom
alexsupa597:chore/call-rimraf-with-npx
Dec 14, 2022
Merged

Chore: call rimraf with npx#2543
Keith-CY merged 1 commit into
nervosnetwork:developfrom
alexsupa597:chore/call-rimraf-with-npx

Conversation

@alexsupa597

@alexsupa597 alexsupa597 commented Dec 13, 2022

Copy link
Copy Markdown

What problem does this PR solve?

As title.

This error(https://github.com/Magickbase/neuron/actions/runs/3627132547/jobs/6116742113#step:8:54) has been found several times in CI.
we used npx to replace installing rimraf to avoid not recognized as an internal or external command.

Ref: Magickbase/neuron-public-issues#86

Check List

Test

e2e Test

Task

none

@Keith-CY

Keith-CY commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

This PR simply removes rimraf from dependencies but dependencies are updated in the yarn.lock, is it as expected?

@alexsupa597

Copy link
Copy Markdown
Author

This PR simply removes rimraf from dependencies but dependencies are updated in the yarn.lock, is it as expected?

@Keith-CY Yeah, actually I've also noticed this before, but this dependency is all from other dependency packages. So, if we just try to solve the error we got, I think it is acceptable. am I right?

image

@alexsupa597

Copy link
Copy Markdown
Author

After removing this dependency I reinstalled all of the dependencies to check our project was normal. So there are some other dependencies that may be upgraded.
image

@Keith-CY
Keith-CY merged commit b0aa8bf into nervosnetwork:develop Dec 14, 2022
@alexsupa597
alexsupa597 deleted the chore/call-rimraf-with-npx branch April 26, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants