Feat/implement dynamic fee rate based on fee rate statistics - #2587
Closed
alexsupa597 wants to merge 11 commits into
Closed
Feat/implement dynamic fee rate based on fee rate statistics#2587alexsupa597 wants to merge 11 commits into
alexsupa597 wants to merge 11 commits into
Conversation
alexsupa597
marked this pull request as draft
February 13, 2023 16:02
MacOS is specified by version number explicitly because tag "macos-latest" refers to macos-11 or macos-12 randomly during GitHub action's transition while macos 12 removed Python 2 which is required by electron-builder. Since latest electron-builder has supported python3, this hotfix will not introduce python2 in host but downgrade it to macos 12 Ref: electron-userland/electron-builder#6606
Contributor
|
Most commits in this PR are not signed |
Author
Yes, it is. I'll create another PR to fix this problem. It maybe cause I use |
Author
alexsupa597
deleted the
feat/implement-dynamic-fee-rate-based-on-fee-rate-statistics
branch
March 28, 2023 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As title.
An RPC to fetch fee_rate_statistics is added since CKB@v0.106.0, which returns mean fee rate and median fee rate of the specified block range.
With the historic data, Neuron could offer more precise fee rate recommendations for users.
PRD: Magickbase/neuron-public-issues#87
UI: https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=319%3A4539&t=oQrWTpg2GhW4obRJ-0
Ref: Magickbase/neuron-public-issues#95
Check List
Test
e2e Test
Task
none