Skip to content

feat: Adapt ckb light node - #2590

Merged
Keith-CY merged 6 commits into
nervosnetwork:support-light-clientfrom
yanguoyu:feat-light-client
Mar 24, 2023
Merged

feat: Adapt ckb light node#2590
Keith-CY merged 6 commits into
nervosnetwork:support-light-clientfrom
yanguoyu:feat-light-client

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Feb 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

How to switch to light client

  1. ./script/download-ckb.sh
  2. start Neuron
  3. Click Network, choose Light Testnet

Light node sync way
Create a sync_progress table to save sync progress.

  1. Call set_script to sync scripts by light node
  2. Every 5s to check if there exists a queue or else create some sync queue
  3. In a sync queue there will check wheater exists txs between blockStart and blockEnd, if exists, it will send tx hashes to the queue class, or else update the sync_progress
  4. Update the sync_progress after queue class using the tx hashes.

Something needs to do before ready
1. Add test cases for added code. I will add test cases later.

Something needs to do later

  1. Support change light node data path.

@yanguoyu
yanguoyu marked this pull request as ready for review February 23, 2023 13:15
@yanguoyu yanguoyu mentioned this pull request Feb 23, 2023
Closed
Keith-CY
Keith-CY reviewed Mar 2, 2023
View reviewed changes
Comment thread packages/neuron-ui/src/components/NetworkTypeLabel/index.tsx Outdated
Comment thread packages/neuron-ui/src/components/NetworkSetting/index.tsx Outdated
Comment thread packages/neuron-wallet/src/block-sync-renderer/index.ts Outdated
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/connector.ts Outdated
@Keith-CY
Keith-CY requested a review from devchenyan March 3, 2023 08:27
Keith-CY
Keith-CY reviewed Mar 3, 2023
View reviewed changes
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/indexer-connector.ts Outdated
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/queue.ts Outdated
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/queue.ts Outdated
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/queue.ts Outdated
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/queue.ts
Comment thread packages/neuron-wallet/src/services/live-cell-service.ts Outdated
Comment thread packages/neuron-wallet/src/services/networks.ts Outdated
Comment thread packages/neuron-wallet/src/services/networks.ts Outdated
Keith-CY
Keith-CY reviewed Mar 9, 2023
View reviewed changes
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/light-connector.ts Outdated
Comment thread packages/neuron-wallet/src/database/chain/entities/sync-progress.ts Outdated
Comment thread packages/neuron-wallet/src/services/settings.ts Outdated
Comment thread packages/neuron-wallet/src/types/controller.d.ts Outdated
Keith-CY
Keith-CY reviewed Mar 9, 2023
View reviewed changes
Comment thread packages/neuron-wallet/src/services/light-runner.ts Outdated
Comment thread packages/neuron-wallet/src/services/light-runner.ts Outdated
@yanguoyu
fix: Use good suggestions in comments.
b3992a6 
1. Rename light_testnet to light_client_testnet
2. Better recognize template type name.
3. Exactly function names and variable names.
Keith-CY
Keith-CY reviewed Mar 10, 2023
View reviewed changes
Comment thread packages/neuron-wallet/src/services/settings.ts Outdated
Comment thread packages/neuron-wallet/src/services/sync-progress.ts Outdated
Comment thread packages/neuron-wallet/src/services/sync-progress.ts Outdated
Comment thread packages/neuron-wallet/src/services/sync-progress.ts Outdated
Keith-CY
Keith-CY reviewed Mar 10, 2023
View reviewed changes
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/light-connector.ts Outdated
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/light-connector.ts Outdated
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/light-connector.ts Outdated
Comment thread packages/neuron-wallet/src/block-sync-renderer/sync/light-connector.ts Outdated
Keith-CY
Keith-CY reviewed Mar 10, 2023
View reviewed changes
Comment thread packages/neuron-wallet/src/services/light-runner.ts
Comment thread packages/neuron-wallet/src/services/light-runner.ts Outdated
Comment thread packages/neuron-wallet/src/services/light-runner.ts Outdated
Comment thread packages/neuron-wallet/src/services/light-runner.ts Outdated
yanguoyu added 2 commits March 14, 2023 15:05
@yanguoyu
fix: fix with suggestions.
189f0c8 
1. Fix rename table's field name.
2. Remove unnecessary calculations for scriptHash
3. Better function name to split into two functions.
@yanguoyu
fix: Return if queue is not empty.
c35ffac
@Keith-CY

Keith-CY commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

CKB light client v0.2.2 has been released and is suggested to be used

Ref: https://github.com/nervosnetwork/ckb-light-client/releases/tag/v0.2.2

@Keith-CY
Keith-CY changed the base branch from develop to support-light-client March 24, 2023 03:40
@Keith-CY
Keith-CY merged commit 2dca3fc into nervosnetwork:support-light-client Mar 24, 2023
yanguoyu added a commit that referenced this pull request Apr 21, 2023
@yanguoyu
feat: Adapt ckb light node (#2590)
b0051f7
Keith-CY added a commit that referenced this pull request May 29, 2023
@Keith-CY @yanguoyu
feat: Adapt ckb light node (#2590) (#2615)
1dfd255 
Co-authored-by: 严国宇 <841185308@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cedar67 Cedar67 Awaiting requested review from Cedar67
@alexsupa597 alexsupa597 Awaiting requested review from alexsupa597
@devchenyan devchenyan Awaiting requested review from devchenyan
1 more reviewer
@Keith-CY Keith-CY Keith-CY approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yanguoyu @Keith-CY