fix: Fix some bugs, details are in description. - #2641
Merged
yanguoyu merged 3 commits intoApr 21, 2023
Conversation
1. Fetch some contract blocks when starting the sync 2. Use `getHeader` to replace `getHeaderByNumber` 3. Get live cells from local SQLITE when generating transactions. 4. Remove `getBlockchainInfo` from UI because chainInfo is not used in UI.
yanguoyu
requested review from
Keith-CY,
WhiteMinds,
alexsupa597 and
devchenyan
April 19, 2023 08:19
Keith-CY
reviewed
Apr 19, 2023
Keith-CY
approved these changes
Apr 19, 2023
alexsupa597
approved these changes
Apr 20, 2023
devchenyan
approved these changes
Apr 21, 2023
yanguoyu
added a commit
that referenced
this pull request
Apr 21, 2023
* fix: Fix some bugs, details are in description. 1. Fetch some contract blocks when starting the sync 2. Use `getHeader` to replace `getHeaderByNumber` 3. Get live cells from local SQLITE when generating transactions. 4. Remove `getBlockchainInfo` from UI because chainInfo is not used in UI. 5. When call setCurrent should restart queue when network is light client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getHeaderto replacegetHeaderByNumbergetBlockchainInfofrom UI because chainInfo is not used in UI.