Skip to content

fix: Show some tips about light client. - #2642

Merged
Keith-CY merged 5 commits into
nervosnetwork:support-light-clientfrom
yanguoyu:fix-light-client
Apr 28, 2023
Merged

fix: Show some tips about light client.#2642
Keith-CY merged 5 commits into
nervosnetwork:support-light-clientfrom
yanguoyu:fix-light-client

Conversation

@yanguoyu

Copy link
Copy Markdown
Contributor
  1. When users select send ckb with lock-time, will also prompt light client will not support showing lock-time cell.

image

  1. Send sudt with Cheque

image

  1. Send sudt to other users' ACP address

When sending ckb sudt
image

When sending other sudt, can only support sending extra 142 CKBytes when sending sudt.

image

@yanguoyu
yanguoyu marked this pull request as ready for review April 21, 2023 06:11
Comment thread packages/neuron-ui/src/components/SUDTSend/index.tsx Outdated
Comment thread packages/neuron-ui/src/locales/en.json Outdated
Comment thread packages/neuron-ui/src/locales/zh-tw.json Outdated
Comment thread packages/neuron-ui/src/locales/zh.json Outdated
Comment thread packages/neuron-wallet/src/locales/en.ts Outdated
Comment thread packages/neuron-wallet/src/locales/zh-tw.ts Outdated
Comment thread packages/neuron-wallet/src/locales/zh.ts Outdated
@Keith-CY

Copy link
Copy Markdown
Contributor

Please review the prompts @Danie0918 @Sven-TBD

@yanguoyu
yanguoyu requested a review from Keith-CY April 21, 2023 08:52
@Danie0918

Copy link
Copy Markdown

Please review the prompts @Danie0918 @Sven-TBD

1.The prompt copy about sending CKB can be more streamlined
[Current]请确保对方钱包能够支持到期解锁功能。一般情况下,交易所不支持到期解锁功能,请谨慎使用!注意: 轻节点模式不支持展示到期解锁的 CKBytes。
[Optimization]请确保对方钱包支持到期解锁功能。(注:1.交易锁一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的CKBytes)
2. Do you need to add the Chinese translation of “cheque”?

@poor-defined

Copy link
Copy Markdown
  1. 请确保接收方钱包支持到期解锁功能。(注:1.交易所一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的CKBytes)
  2. "注意: 轻节点模式不支持展示到期解锁的 CKBytes。" Does this mean that the Locked CKBytes will be counted into the finalized value, like balance , without being distinguished from free one, or will it not be counted into the finalized value at all?

@yanguoyu

Copy link
Copy Markdown
Contributor Author
  1. 请确保接收方钱包支持到期解锁功能。(注:1.交易所一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的CKBytes)
  2. "注意: 轻节点模式不支持展示到期解锁的 CKBytes。" Does this mean that the Locked CKBytes will be counted into the finalized value, like balance , without being distinguished from free one, or will it not be counted into the finalized value at all?

Warning: Light client mode doesn't support showing lock-time CKBytes. this means Neuron will not collect these cells, so it will not be included everywhere.

@yanguoyu

Copy link
Copy Markdown
Contributor Author

I add the show light client version with commit.

image

@Keith-CY

Copy link
Copy Markdown
Contributor

Are the prompts ready to merge? @Danie0918 @Sven-TBD

@Danie0918

Danie0918 commented Apr 25, 2023

Copy link
Copy Markdown

Are the prompts ready to merge? @Danie0918 @Sven-TBD

1.The prompt copy about sending CKB can be more streamlined
[Current]请确保对方钱包能够支持到期解锁功能。一般情况下,交易所不支持到期解锁功能,请谨慎使用!注意: 轻节点模式不支持展示到期解锁的 CKBytes。
[Optimization]请确保对方钱包支持到期解锁功能。(注:1.交易锁一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的CKBytes)
2. Do you need to add the Chinese translation of “cheque”?

About 1, no changes have been seen in files changed. In 2, chengque should be a proper noun for consulting related documents. It can be ignored without translation.

@yanguoyu

Copy link
Copy Markdown
Contributor Author

Are the prompts ready to merge? @Danie0918 @Sven-TBD

1.The prompt copy about sending CKB can be more streamlined [Current]请确保对方钱包能够支持到期解锁功能。一般情况下,交易所不支持到期解锁功能,请谨慎使用!注意: 轻节点模式不支持展示到期解锁的 CKBytes。 [Optimization]请确保对方钱包支持到期解锁功能。(注:1.交易锁一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的CKBytes) 2. Do you need to add the Chinese translation of “cheque”?

About 1, no changes have been seen. In 2, chengque should be a proper noun for consulting related documents. It can be ignored without translation.

When the network is testnet, it will show 注意: 轻节点模式不支持展示到期解锁的 CKBytes. But if the network is mainnet, it will not show this. Should we use the older prompt with mainnet and use the new prompt when the network is testnet?

@Keith-CY

Copy link
Copy Markdown
Contributor

Are the prompts ready to merge? @Danie0918 @Sven-TBD

1.The prompt copy about sending CKB can be more streamlined [Current]请确保对方钱包能够支持到期解锁功能。一般情况下,交易所不支持到期解锁功能,请谨慎使用!注意: 轻节点模式不支持展示到期解锁的 CKBytes。 [Optimization]请确保对方钱包支持到期解锁功能。(注:1.交易锁一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的CKBytes) 2. Do you need to add the Chinese translation of “cheque”?
About 1, no changes have been seen. In 2, chengque should be a proper noun for consulting related documents. It can be ignored without translation.

When the network is testnet, it will show 注意: 轻节点模式不支持展示到期解锁的 CKBytes. But if the network is mainnet, it will not show this. Should we use the older prompt with mainnet and use the new prompt when the network is testnet?

It would be better to keep the old prompt for mainnet and append the light-client-relevant prompt when light-client is connected to.

@yanguoyu

Copy link
Copy Markdown
Contributor Author

Are the prompts ready to merge? @Danie0918 @Sven-TBD

1.The prompt copy about sending CKB can be more streamlined [Current]请确保对方钱包能够支持到期解锁功能。一般情况下,交易所不支持到期解锁功能,请谨慎使用!注意: 轻节点模式不支持展示到期解锁的 CKBytes。 [Optimization]请确保对方钱包支持到期解锁功能。(注:1.交易锁一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的CKBytes) 2. Do you need to add the Chinese translation of “cheque”?
About 1, no changes have been seen. In 2, chengque should be a proper noun for consulting related documents. It can be ignored without translation.

When the network is testnet, it will show 注意: 轻节点模式不支持展示到期解锁的 CKBytes. But if the network is mainnet, it will not show this. Should we use the older prompt with mainnet and use the new prompt when the network is testnet?

It would be better to keep the old prompt for mainnet and append the light-client-relevant prompt when light-client is connected to.

@Danie0918 So I will not change the prompt about lock-time. Do you have any suggestions?

@Danie0918

Copy link
Copy Markdown

Are the prompts ready to merge? @Danie0918 @Sven-TBD

1.The prompt copy about sending CKB can be more streamlined [Current]请确保对方钱包能够支持到期解锁功能。一般情况下,交易所不支持到期解锁功能,请谨慎使用!注意: 轻节点模式不支持展示到期解锁的 CKBytes。 [Optimization]请确保对方钱包支持到期解锁功能。(注:1.交易锁一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的CKBytes) 2. Do you need to add the Chinese translation of “cheque”?
About 1, no changes have been seen. In 2, chengque should be a proper noun for consulting related documents. It can be ignored without translation.

When the network is testnet, it will show 注意: 轻节点模式不支持展示到期解锁的 CKBytes. But if the network is mainnet, it will not show this. Should we use the older prompt with mainnet and use the new prompt when the network is testnet?

It would be better to keep the old prompt for mainnet and append the light-client-relevant prompt when light-client is connected to.

@Danie0918 So I will not change the prompt about lock-time. Do you have any suggestions?

I just feel that the prompt copy is too long, and I want to optimize the structure of the prompt so that users can read it.

@Keith-CY

Copy link
Copy Markdown
Contributor

Are the prompts ready to merge? @Danie0918 @Sven-TBD

1.The prompt copy about sending CKB can be more streamlined [Current]请确保对方钱包能够支持到期解锁功能。一般情况下,交易所不支持到期解锁功能,请谨慎使用!注意: 轻节点模式不支持展示到期解锁的 CKBytes。 [Optimization]请确保对方钱包支持到期解锁功能。(注:1.交易锁一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的CKBytes) 2. Do you need to add the Chinese translation of “cheque”?
About 1, no changes have been seen. In 2, chengque should be a proper noun for consulting related documents. It can be ignored without translation.

When the network is testnet, it will show 注意: 轻节点模式不支持展示到期解锁的 CKBytes. But if the network is mainnet, it will not show this. Should we use the older prompt with mainnet and use the new prompt when the network is testnet?

It would be better to keep the old prompt for mainnet and append the light-client-relevant prompt when light-client is connected to.

@Danie0918 So I will not change the prompt about lock-time. Do you have any suggestions?

I just feel that the prompt copy is too long, and I want to optimize the structure of the prompt so that users can read it.

I missed something.

So the recommendation is

请确保对方钱包支持到期解锁功能。(注:1.交易所一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的CKBytes)

I think it's clear, but point 1 should be displayed when connected to a full node, so it should be

full node:
请确保对方钱包支持到期解锁功能。(注:1.交易所一般不支持到期解锁功能)

light client:
请确保对方钱包支持到期解锁功能。(注:1.交易所一般不支持到期解锁功能 2.轻节点钱包无法显示到期解锁的 CKBytes)

@yanguoyu

Copy link
Copy Markdown
Contributor Author

1307164
For testnet:
image

For mainnet:

image

@Keith-CY
Keith-CY merged commit 97c9bc0 into nervosnetwork:support-light-client Apr 28, 2023
@yanguoyu
yanguoyu deleted the fix-light-client branch May 4, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants