fix: set default fee rate if fee rate api throws - #2673
Merged
Conversation
Keith-CY
requested review from
FrederLu,
WhiteMinds,
alexsupa597,
devchenyan,
littleLip520,
silySuper and
yanguoyu
May 18, 2023 09:16
yanguoyu
approved these changes
May 18, 2023
alexsupa597
approved these changes
May 18, 2023
silySuper
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed an alert comes from a failed API request to fetch fee rate statistics, which will be displayed on each page of
sending transactionMeanwhile, if the API throws, the suggested fee rate will be reset to the default value.
Before:
After:
