Skip to content

chore: upgrade dependencies - #2724

Merged
Keith-CY merged 14 commits into
nervosnetwork:developfrom
Magickbase:develop
Jun 25, 2023
Merged

chore: upgrade dependencies#2724
Keith-CY merged 14 commits into
nervosnetwork:developfrom
Magickbase:develop

Conversation

@Keith-CY

@Keith-CY Keith-CY commented Jun 18, 2023

Copy link
Copy Markdown
Contributor

The following dependencies are going to be updated

Verification State Dep Name&Desc
@babel/core
@babel/node
concurrently
lerna
lint-staged
prettier
wait-on
@babel/plugin-proposal-private-property-in-object
@types/react
usb
@types/enzyme
@types/react-dom
@electron/notarize
@types/async
@nervosnetwork/ckb-types

Note: Dependency usb should be verified @FrederLu who has a hardware wallet, so an approval from @FrederLu is required

@github-actions

Copy link
Copy Markdown
Contributor

Packaging for test is done in 5304360535 for commit 1ab6605 .

@github-actions

Copy link
Copy Markdown
Contributor

Packaging for test is done in 5308660068 for commit adc8ce2 .

@github-actions

Copy link
Copy Markdown
Contributor

Packaging for test is done in 5319156651 for commit ee59c00 .

@github-actions

Copy link
Copy Markdown
Contributor

Packaging for test is done in 5319240844 for commit 92309af .

@Keith-CY
Keith-CY marked this pull request as ready for review June 20, 2023 06:57
@Keith-CY

Copy link
Copy Markdown
Contributor Author

This PR updates dependencies and has nothing to do with functionalities, please have a review
@zhangyouxin @homura @WhiteMinds @devchenyan @yanguoyu @JeffreyMa597

Verification of usb and @ledgerhq/hw-transport-node-hid requires the hardware wallet, need help from @FrederLu

@github-actions

Copy link
Copy Markdown
Contributor

Packaging for test is done in 5319344416 for commit 4de2324 .

@FrederLu

FrederLu commented Jun 20, 2023

Copy link
Copy Markdown

Packaging for test is done in 5319344416 for commit 4de2324 .

After linking Ledger, using Neuron transaction or adding a hardware wallet prompts that the connection cannot be recognized.
image
image

@yanguoyu

Copy link
Copy Markdown
Contributor

Packaging for test is done in 5319344416 for commit 4de2324 .

After linking Ledger, using Neuron transaction or adding a hardware wallet prompts that the connection cannot be recognized. image image

The nano s plus also happens like that, I will check what causes that.

@Keith-CY

Copy link
Copy Markdown
Contributor Author

Packaging for test is done in 5319344416 for commit 4de2324 .

After linking Ledger, using Neuron transaction or adding a hardware wallet prompts that the connection cannot be recognized. image image

The updates on new-ui-design has been merged into this PR, please check if it works @FrederLu

@FrederLu

Copy link
Copy Markdown

Packaging for test is done in 5319344416 for commit 4de2324 .

After linking Ledger, using Neuron transaction or adding a hardware wallet prompts that the connection cannot be recognized. image image

The updates on new-ui-design has been merged into this PR, please check if it works @FrederLu

Packaging seems to be abnormal.

@Keith-CY

Copy link
Copy Markdown
Contributor Author

Packaging for test is done in 5319344416 for commit 4de2324 .

After linking Ledger, using Neuron transaction or adding a hardware wallet prompts that the connection cannot be recognized. image image

The updates on new-ui-design has been merged into this PR, please check if it works @FrederLu

Packaging seems to be abnormal.

It's still being packaged at https://github.com/nervosnetwork/neuron/actions/runs/5320762602?pr=2724

@github-actions

Copy link
Copy Markdown
Contributor

Packaging for test is done in 5320762602 for commit cc58ca0 .

@Keith-CY
Keith-CY enabled auto-merge June 20, 2023 16:56
@github-actions

Copy link
Copy Markdown
Contributor

Packaging for test is done in 5326392846 for commit 647a3b8 .

@github-actions

Copy link
Copy Markdown
Contributor

Packaging for test is done in 5326399680 for commit 40a4d2e .

@FrederLu

Copy link
Copy Markdown

Packaging for test is done in 5326399680 for commit 40a4d2e .

This package is still unable to connect.
image
image

@FrederLu

Copy link
Copy Markdown

link :#2716 (comment)
The packages linked above are linkable.
image

@yanguoyu

yanguoyu commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

The node module usb in @ledgerhq/hw-transport-node-hid's dependencies is ^1.7.0.
Maybe we can remove the resolutions of usb. I have checked import hard wallet and send ckb from hard wallet.

The usb's version is locked by #2541

@Keith-CY

Copy link
Copy Markdown
Contributor Author

Does remove the resolutions of usb mean removing it from this PR, or removing it from the dependencies

@yanguoyu

Copy link
Copy Markdown
Contributor

Does remove the resolutions of usb mean removing it from this PR, or removing it from the dependencies

I mean removing it from the dependencies, but we'd better check whether it works in M1 because of #2541.

@Keith-CY

Copy link
Copy Markdown
Contributor Author

Does remove the resolutions of usb mean removing it from this PR, or removing it from the dependencies

I mean removing it from the dependencies, but we'd better check whether it works in M1 because of #2541.

I see, the update of usb will be removed from this PR first

@github-actions

Copy link
Copy Markdown
Contributor

Packaging for test is done in 5333094886 for commit b8e6d3c .

@FrederLu

Copy link
Copy Markdown

Packaging for test is done in 5333094886 for commit b8e6d3c .

This package can be connected and signed using Ledger Nano X.

@homura homura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Keith-CY
Keith-CY disabled auto-merge June 25, 2023 03:42
@Keith-CY
Keith-CY merged commit 112af4e into nervosnetwork:develop Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants