Refactor: remove ckb-sdk-utils and repalce with lumos

packages/neuron-wallet/package.json

@@ -40,6 +40,7 @@
     "@ckb-lumos/base": "0.20.0-alpha.3",
     "@ckb-lumos/ckb-indexer": "0.20.0-alpha.3",
     "@ckb-lumos/codec": "0.20.0-alpha.3",
+    "@ckb-lumos/lumos": "0.20.0-alpha.3",
     "@ckb-lumos/rpc": "0.20.0-alpha.3",
     "@iarna/toml": "2.2.5",
     "@ledgerhq/hw-transport-node-hid": "6.27.15",

packages/neuron-wallet/src/block-sync-renderer/sync/light-connector.ts

@@ -8,7 +8,7 @@ import AddressMeta from '../../database/address/meta'
 import { scheduler } from 'timers/promises'
 import SyncProgressService from '../../services/sync-progress'
 import { BlockTips, LumosCellQuery, Connector, AppendScript } from './connector'
-import { scriptToHash } from '@nervosnetwork/ckb-sdk-utils'
+import { utils } from '@ckb-lumos/lumos'
 import { FetchTransactionReturnType, LightRPC, LightScriptFilter } from '../../utils/ckb-rpc'
 import HexUtils from '../../utils/hex'
 import Multisig from '../../services/multisig'
@@ -125,7 +125,7 @@ export default class LightConnector extends Connector<CKBComponents.Hash> {
       }
     })
     syncScripts.forEach(syncScript => {
-      const scriptHash = scriptToHash(syncScript.script)
+      const scriptHash = utils.computeScriptHash(syncScript.script)
       const syncStatus = syncStatusMap.get(scriptHash)
       if (
         syncStatus &&
@@ -159,7 +159,7 @@ export default class LightConnector extends Connector<CKBComponents.Hash> {
     const syncScripts = await this.lightRpc.getScripts()
     const existSyncscripts: Record<string, LightScriptFilter> = {}
     syncScripts.forEach(v => {
-      existSyncscripts[scriptToHash(v.script)] = v
+      existSyncscripts[utils.computeScriptHash(v.script)] = v
     })
     const currentWalletId = WalletService.getInstance().getCurrent()?.id
     const allScripts = this.addressMetas
@@ -188,15 +188,15 @@ export default class LightConnector extends Connector<CKBComponents.Hash> {
       ...allScripts.map(v => ({
         ...v,
         blockNumber:
-          existSyncscripts[scriptToHash(v.script)]?.blockNumber ??
+          existSyncscripts[utils.computeScriptHash(v.script)]?.blockNumber ??
           walletStartBlockMap[v.walletId] ??
           `0x${(walletMinBlockNumber?.[v.walletId] ?? 0).toString(16)}`,
       })),
       ...appendScripts.map(v => ({
         ...v,
         blockNumber:
-          existSyncscripts[scriptToHash(v.script)]?.blockNumber ??
-          `0x${(otherTypeSyncProgress[scriptToHash(v.script)] ?? 0).toString(16)}`,
+          existSyncscripts[utils.computeScriptHash(v.script)]?.blockNumber ??
+          `0x${(otherTypeSyncProgress[utils.computeScriptHash(v.script)] ?? 0).toString(16)}`,
       })),
     ]
     await this.lightRpc.setScripts(setScriptsParams)
@@ -205,7 +205,7 @@ export default class LightConnector extends Connector<CKBComponents.Hash> {
     await SyncProgressService.updateSyncProgressFlag(walletIds)
     await SyncProgressService.removeByHashesAndAddressType(
       SyncAddressType.Multisig,
-      appendScripts.map(v => scriptToHash(v.script))
+      appendScripts.map(v => utils.computeScriptHash(v.script))
     )
   }
 

packages/neuron-wallet/src/block-sync-renderer/sync/tx-address-finder.ts

@@ -1,5 +1,5 @@
 import { getConnection } from 'typeorm'
-import { scriptToAddress } from '@nervosnetwork/ckb-sdk-utils'
+import { config, helpers } from '@ckb-lumos/lumos'
 import OutputEntity from '../../database/chain/entities/output'
 import NetworksService from '../../services/networks'
 import Output from '../../models/chain/output'
@@ -33,7 +33,8 @@ export default class TxAddressFinder {
 
     const outputsResult: [boolean, Output[], AnyoneCanPayInfo[]] = this.selectOutputs()
     const isMainnet = NetworksService.getInstance().isMainnet()
-    const outputAddresses: string[] = outputsResult[1].map(output => scriptToAddress(output.lock, isMainnet))
+    const lumosOptions = isMainnet ? { config: config.predefined.LINA } : { config: config.predefined.AGGRON4 }
+    const outputAddresses: string[] = outputsResult[1].map(output => helpers.encodeToAddress(output.lock, lumosOptions))
 
     return [
       inputAddressesResult[0] || outputsResult[0],
@@ -86,6 +87,7 @@ export default class TxAddressFinder {
     const anyoneCanPayInfos: AnyoneCanPayInfo[] = []
     const inputs = this.tx.inputs!.filter(i => i.previousOutput !== null)
     const isMainnet = NetworksService.getInstance().isMainnet()
+    const lumosOptions = isMainnet ? { config: config.predefined.LINA } : { config: config.predefined.AGGRON4 }
 
     let shouldSync = false
     for (const input of inputs) {
@@ -104,7 +106,7 @@ export default class TxAddressFinder {
       }
       if (output && this.lockHashes.has(output.lockHash)) {
         shouldSync = true
-        addresses.push(scriptToAddress(output.lockScript(), isMainnet))
+        addresses.push(helpers.encodeToAddress(output.lockScript(), lumosOptions))
       }
       if (output && SystemScriptInfo.isMultiSignScript(output.lockScript())) {
         const multiSignBlake160 = output.lockScript().args.slice(0, 42)

packages/neuron-wallet/src/controllers/asset-account.ts

@@ -1,4 +1,4 @@
-import { scriptToAddress } from '@nervosnetwork/ckb-sdk-utils'
+import { config, helpers } from '@ckb-lumos/lumos'
 import AssetAccount from '../models/asset-account'
 import Transaction from '../models/chain/transaction'
 import AssetAccountService from '../services/asset-account-service'
@@ -81,11 +81,12 @@ export default class AssetAccountController {
     }
 
     const isMainnet = NetworksService.getInstance().isMainnet()
+    const lumosOptions = isMainnet ? { config: config.predefined.LINA } : { config: config.predefined.AGGRON4 }
 
     const result = assetAccounts.map(aa => {
       return {
         ...aa,
-        address: scriptToAddress(assetAccountInfo.generateAnyoneCanPayScript(aa.blake160), isMainnet),
+        address: helpers.encodeToAddress(assetAccountInfo.generateAnyoneCanPayScript(aa.blake160), lumosOptions),
       }
     })
 
@@ -125,12 +126,13 @@ export default class AssetAccountController {
 
     const assetAccountInfo = new AssetAccountInfo()
     const isMainnet = NetworksService.getInstance().isMainnet()
+    const lumosOptions = isMainnet ? { config: config.predefined.LINA } : { config: config.predefined.AGGRON4 }
 
     return {
       status: ResponseCode.Success,
       result: {
         ...account,
-        address: scriptToAddress(assetAccountInfo.generateAnyoneCanPayScript(account.blake160), isMainnet),
+        address: helpers.encodeToAddress(assetAccountInfo.generateAnyoneCanPayScript(account.blake160), lumosOptions),
       },
     }
   }

packages/neuron-wallet/src/controllers/multisig.ts

@@ -2,7 +2,6 @@ import fs from 'fs'
 import path from 'path'
 import { dialog, BrowserWindow } from 'electron'
 import { t } from 'i18next'
-import { addressToScript, scriptToAddress, scriptToHash } from '@nervosnetwork/ckb-sdk-utils'
 import { ResponseCode } from '../utils/const'
 import MultisigConfig from '../database/chain/entities/multisig-config'
 import MultisigConfigModel from '../models/multisig-config'
@@ -12,6 +11,7 @@ import OfflineSignService from '../services/offline-sign'
 import Multisig from '../models/multisig'
 import SystemScriptInfo from '../models/system-script-info'
 import NetworksService from '../services/networks'
+import { config as lumosConig, helpers, utils, config } from '@ckb-lumos/lumos'
 
 interface MultisigConfigOutput {
   multisig_configs: Record<
@@ -122,7 +122,13 @@ export default class MultisigController {
         r: +config.require_first_n,
         m: +config.threshold,
         n: config.sighash_addresses.length,
-        blake160s: config.sighash_addresses.map(v => addressToScript(v).args),
+        blake160s: config.sighash_addresses.map(v => {
+          const isMainnet = v.startsWith('ckb')
+          const lumosOptions = isMainnet
+            ? { config: lumosConig.predefined.LINA }
+            : { config: lumosConig.predefined.AGGRON4 }
+          return helpers.addressToScript(v, lumosOptions).args
+        }),
         walletId,
         alias: config.alias,
       }))
@@ -170,11 +176,13 @@ export default class MultisigController {
       return
     }
     const isMainnet = NetworksService.getInstance().isMainnet()
+    const lumosOptions = isMainnet ? { config: lumosConig.predefined.LINA } : { config: lumosConig.predefined.AGGRON4 }
+
     const output: MultisigConfigOutput = { multisig_configs: {} }
     configs.forEach(v => {
       output.multisig_configs[Multisig.hash(v.blake160s, v.r, v.m, v.n)] = {
         sighash_addresses: v.blake160s.map(args =>
-          scriptToAddress(SystemScriptInfo.generateSecpScript(args), isMainnet)
+          helpers.encodeToAddress(SystemScriptInfo.generateSecpScript(args), lumosOptions)
         ),
         require_first_n: v.r,
         threshold: v.m,
@@ -214,7 +222,9 @@ export default class MultisigController {
       }
     }
     const tx = result.json
-    const lockHash = scriptToHash(addressToScript(fullPayload))
+    const isMainnet = fullPayload.startsWith('ckb')
+    const lumosOptions = isMainnet ? { config: config.predefined.LINA } : { config: config.predefined.AGGRON4 }
+    const lockHash = utils.computeScriptHash(helpers.addressToScript(fullPayload, lumosOptions))
     if (tx.transaction.inputs.every(v => v.lockHash !== lockHash)) {
       dialog.showErrorBox(t('common.error'), t('messages.multisig-lock-hash-mismatch'))
       return {

packages/neuron-wallet/src/controllers/sudt.ts

@@ -1,4 +1,4 @@
-import { scriptToHash } from '@nervosnetwork/ckb-sdk-utils'
+import { utils } from '@ckb-lumos/lumos'
 import LiveCellService from '../services/live-cell-service'
 import AssetAccountInfo from '../models/asset-account-info'
 import Script, { ScriptHashType } from '../models/chain/script'
@@ -41,7 +41,7 @@ export default class SUDTController {
     const script = new Script(assetAcount.infos.sudt.codeHash, params.tokenID, assetAcount.infos.sudt.hashType)
     return {
       status: ResponseCode.Success,
-      result: scriptToHash(script.toSDK()),
+      result: utils.computeScriptHash(script.toSDK()),
     }
   }
 }

packages/neuron-wallet/src/database/chain/entities/multisig-output.ts

@@ -1,7 +1,7 @@
 import { Entity, BaseEntity, Column, PrimaryColumn } from 'typeorm'
 import Script, { ScriptHashType } from '../../../models/chain/script'
 import OutPoint from '../../../models/chain/out-point'
-import { scriptToHash } from '@nervosnetwork/ckb-sdk-utils'
+import { utils } from '@ckb-lumos/lumos'
 import { OutputStatus } from '../../../models/chain/output'
 
 @Entity()
@@ -71,7 +71,7 @@ export default class MultisigOutput extends BaseEntity {
     entity.lockArgs = params.output.lock.args
     entity.lockCodeHash = params.output.lock.code_hash
     entity.lockHashType = params.output.lock.hash_type as ScriptHashType
-    entity.lockHash = scriptToHash({
+    entity.lockHash = utils.computeScriptHash({
       args: entity.lockArgs,
       codeHash: entity.lockCodeHash,
       hashType: entity.lockHashType,

packages/neuron-wallet/src/database/chain/entities/sync-progress.ts

@@ -1,5 +1,5 @@
 import { HexString } from '@ckb-lumos/base'
-import { scriptToHash } from '@nervosnetwork/ckb-sdk-utils'
+import { utils } from '@ckb-lumos/lumos'
 import { Entity, PrimaryColumn, Column } from 'typeorm'
 
 export enum SyncAddressType {
@@ -49,7 +49,7 @@ export default class SyncProgress {
     addressType?: SyncAddressType
   }) {
     const res = new SyncProgress()
-    res.hash = scriptToHash(obj.script)
+    res.hash = utils.computeScriptHash(obj.script)
     res.args = obj.script.args
     res.codeHash = obj.script.codeHash
     res.hashType = obj.script.hashType

packages/neuron-wallet/src/database/chain/migrations/1650984779265-UpdateAddressDescription.ts

@@ -1,14 +1,17 @@
-import { MigrationInterface, QueryRunner } from "typeorm";
-import { scriptToAddress, addressToScript } from '@nervosnetwork/ckb-sdk-utils'
+import { MigrationInterface, QueryRunner } from 'typeorm'
 import AddressDescription from '../entities/address-description'
+import { config, helpers } from '@ckb-lumos/lumos'
 
 export class UpdateAddressDescription1650984779265 implements MigrationInterface {
   name = 'UpdateAddressDescription1650984779265'
 
   public async up(queryRunner: QueryRunner): Promise<any> {
     const descList = await queryRunner.manager.find(AddressDescription)
+
     const updated = descList.map(desc => {
-      desc.address = scriptToAddress(addressToScript(desc.address), desc.address.startsWith('ckb'))
+      const isMainnet = desc.address.startsWith('ckb')
+      const lumosOptions = isMainnet ? { config: config.predefined.LINA } : { config: config.predefined.AGGRON4 }
+      desc.address = helpers.encodeToAddress(helpers.addressToScript(desc.address), lumosOptions)
       return desc
     })
     await queryRunner.manager.save(updated)
@@ -17,5 +20,4 @@ export class UpdateAddressDescription1650984779265 implements MigrationInterface
   public async down(): Promise<void> {
     // do nothing
   }
-
 }

packages/neuron-wallet/src/database/chain/migrations/1651820157100-RemoveAddressesMultisigConfig.ts

@@ -1,23 +1,22 @@
-import { MigrationInterface, QueryRunner } from "typeorm"
-import { addressToScript } from "@nervosnetwork/ckb-sdk-utils"
-import MultisigConfig from "../entities/multisig-config"
+import { MigrationInterface, QueryRunner } from 'typeorm'
+import MultisigConfig from '../entities/multisig-config'
+import { helpers } from '@ckb-lumos/lumos'
 
 export class RemoveAddressesMultisigConfig1651820157100 implements MigrationInterface {
-    name = 'RemoveAddressesMultisigConfig1651820157100'
+  name = 'RemoveAddressesMultisigConfig1651820157100'
 
-    public async up(queryRunner: QueryRunner): Promise<any> {
-      await queryRunner.renameColumn('multisig_config', 'addresses', 'blake160s')
-      await queryRunner.dropColumn('multisig_config', 'fullpayload')
-      const configList = await queryRunner.manager.find(MultisigConfig)
-      const updated = configList.map(v => {
-        v.blake160s = v.blake160s.map(v => addressToScript(v).args)
-        return v
-      })
-      await queryRunner.manager.save(updated)
-    }
-
-    public async down(): Promise<void> {
-      // do nothing
-    }
+  public async up(queryRunner: QueryRunner): Promise<any> {
+    await queryRunner.renameColumn('multisig_config', 'addresses', 'blake160s')
+    await queryRunner.dropColumn('multisig_config', 'fullpayload')
+    const configList = await queryRunner.manager.find(MultisigConfig)
+    const updated = configList.map(v => {
+      v.blake160s = v.blake160s.map(v => helpers.addressToScript(v).args)
+      return v
+    })
+    await queryRunner.manager.save(updated)
+  }
 
+  public async down(): Promise<void> {
+    // do nothing
+  }
 }

packages/neuron-wallet/src/database/chain/migrations/1652945662504-UpdateOutputChequeLockHash.ts

@@ -1,34 +1,34 @@
-import { In, MigrationInterface, QueryRunner } from "typeorm";
-import { scriptToHash } from '@nervosnetwork/ckb-sdk-utils'
-import { ScriptHashType } from "../../../models/chain/script";
-import Output from "../entities/output";
+import { In, MigrationInterface, QueryRunner } from 'typeorm'
+import { utils } from '@ckb-lumos/lumos'
+import { ScriptHashType } from '../../../models/chain/script'
+import Output from '../entities/output'
 
 export class UpdateOutputChequeLockHash1652945662504 implements MigrationInterface {
   name = 'UpdateOutputChequeLockHash1652945662504'
 
   public async up(queryRunner: QueryRunner): Promise<any> {
     const errLockHash = [
-      scriptToHash({
+      utils.computeScriptHash({
         args: '0x' + '0'.repeat(80),
         codeHash: process.env.TESTNET_CHEQUE_SCRIPT_CODEHASH!,
-        hashType: process.env.TESTNET_CHEQUE_SCRIPT_HASHTYPE! as ScriptHashType
+        hashType: process.env.TESTNET_CHEQUE_SCRIPT_HASHTYPE! as ScriptHashType,
       }),
-      scriptToHash({
+      utils.computeScriptHash({
         args: '0x' + '0'.repeat(80),
         codeHash: process.env.MAINNET_CHEQUE_SCRIPT_CODEHASH!,
-        hashType: process.env.MAINNET_CHEQUE_SCRIPT_HASHTYPE! as ScriptHashType
-      })
+        hashType: process.env.MAINNET_CHEQUE_SCRIPT_HASHTYPE! as ScriptHashType,
+      }),
     ]
     const chequeOutput = await queryRunner.connection
       .getRepository(Output)
       .createQueryBuilder('output')
       .where({ lockHash: In(errLockHash) })
       .getMany()
     const updated = chequeOutput.map(output => {
-      output.lockHash = scriptToHash({
+      output.lockHash = utils.computeScriptHash({
         args: output.lockArgs,
         hashType: output.lockHashType,
-        codeHash: output.lockCodeHash
+        codeHash: output.lockCodeHash,
       })
       return output
     })
@@ -38,5 +38,4 @@ export class UpdateOutputChequeLockHash1652945662504 implements MigrationInterfa
   public async down(): Promise<void> {
     // do nothing
   }
-
 }