feat:Detect new upgrade on launch - #2769
Conversation
|
It will open a dialog like that if there is no update when I open the setting page. @JeffreyMa597 
And if there is no update when I open Neuron, but after a while, there exists an update version, when I click exception.movOn the other hand, do we only check once when we open Neuron or should we check for updates every some intervals? @Danie0918 |
| const [searchParams] = useSearchParams() | ||
| const [errorMsg, setErrorMsg] = useState('') | ||
| const [dialogType, setDialogType] = useState<'' | 'checking' | 'updating' | 'updated'>('') | ||
| const [dialogType, setDialogType] = useState<'' | 'checking' | 'checked' | 'updating' | 'updated'>('') |
There was a problem hiding this comment.
The new type checked can be avoided by const isChecked = !!updater.version
There was a problem hiding this comment.
The new type
checkedcan be avoided byconst isChecked = !!updater.version
In the logic of the function handleUpdate, there needs to a key to open our installation dialog, and on the other hand, we don't want the installation dialog to open as soon as we enter the page.
I would suggest checking new updates daily because some may keep Neuron open if it synchronizes slowly. The case may be rare but the cost is low |
Yes, it is true that there may be users who keep Neuron open. So here we need to add a daily check in addition to the open check, how about we set it to UTC+0 check? |
|
/package Packaging for test is done in 5554741165. @JeffreyMa597 |
If we check it at UTC+0, we should check whether the current is UTC+0 every period of time. How about checking it every period of time? |
OK, set up a 24-hour check. |
|
Close with #2783 |
4 participants
What problem does this PR solve?
As title.
2023-07-12.17.38.46.mov
Ref: Magickbase/neuron-public-issues#139
Check List
Test
e2e Test