Skip to content

feat: Add check ckb node update or compatibility - #2808

Merged
Keith-CY merged 2 commits into
nervosnetwork:developfrom
yanguoyu:feat-ckb-check
Aug 24, 2023
Merged

feat: Add check ckb node update or compatibility#2808
Keith-CY merged 2 commits into
nervosnetwork:developfrom
yanguoyu:feat-ckb-check

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

All of the scenes should start ckb external.

  1. When Neuron has an updated version, and the running external ckb version is bigger than Neuron's internal ckb version
    This scene can test with Test show update neuron #2807, the external ckb version should be bigger than v0.109.0
image
  1. When the running external ckb version is not compatible with Neuron.
    This scene can be tested with the current pr package, and the external ckb version should not be 0.109 ~ 0.110
image

@yanguoyu yanguoyu mentioned this pull request Aug 16, 2023
Closed
Keith-CY
Keith-CY reviewed Aug 17, 2023
View reviewed changes
Comment thread packages/neuron-ui/src/services/remote/app.ts Outdated
Comment thread packages/neuron-ui/src/widgets/AlertDialog/index.tsx
Comment thread packages/neuron-wallet/src/services/node.ts
Comment thread packages/neuron-wallet/src/services/node.ts Outdated
Comment thread packages/neuron-wallet/src/services/node.ts Outdated
@yanguoyu
yanguoyu force-pushed the feat-ckb-check branch 3 times, most recently from 01e461d to 7bf2f00 Compare August 17, 2023 11:58
@yanguoyu
yanguoyu requested a review from Keith-CY August 17, 2023 12:00
@yanguoyu

yanguoyu commented Aug 18, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 5946417713. @yanguoyu

@silySuper

silySuper commented Aug 18, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

/package

Packaging for test is done in 5900767298. @silySuper

@yanguoyu yanguoyu mentioned this pull request Aug 18, 2023
Closed
Keith-CY
Keith-CY reviewed Aug 22, 2023
View reviewed changes
Comment thread compatible.csv Outdated
Comment thread packages/neuron-wallet/src/services/node.ts Outdated
@Keith-CY
Keith-CY added this pull request to the merge queue Aug 24, 2023
Merged via the queue into nervosnetwork:develop with commit f7d28f2 Aug 24, 2023
@Keith-CY Keith-CY mentioned this pull request Aug 25, 2023
Closed
@yanguoyu
yanguoyu deleted the feat-ckb-check branch August 25, 2023 07:58
@Keith-CY Keith-CY mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@homura homura Awaiting requested review from homura
@WhiteMinds WhiteMinds Awaiting requested review from WhiteMinds
@FrederLu FrederLu Awaiting requested review from FrederLu
3 more reviewers
@Keith-CY Keith-CY Keith-CY approved these changes
@devchenyan devchenyan devchenyan approved these changes
@silySuper silySuper silySuper approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanguoyu @silySuper @Keith-CY @devchenyan