Skip to content

feat: Change default network name to Internal Node - #2813

Merged
Keith-CY merged 2 commits into
nervosnetwork:developfrom
yanguoyu:feat-network-default
Aug 31, 2023
Merged

feat: Change default network name to Internal Node#2813
Keith-CY merged 2 commits into
nervosnetwork:developfrom
yanguoyu:feat-network-default

Conversation

@yanguoyu

Copy link
Copy Markdown
Contributor
  1. Download and install Neuron for the first time. We can mock this to delete the network.json file at /Users/{username}/Library/Application Support/Neuron/networks/index.json

before:

image

after migrate:

image
  1. Has added a new network but not edit the default network

before:

image

after migrate:

image
  1. Has added a new network and edited the default network

before:

image

after migrate:

image

Comment thread packages/neuron-ui/src/widgets/AlertDialog/index.tsx
@yanguoyu
yanguoyu force-pushed the feat-network-default branch from b69eb7e to def7d52 Compare August 29, 2023 07:13
@silySuper

silySuper commented Aug 29, 2023

Copy link
Copy Markdown

/package.
Packaging for test is done in 6010412901. @silySuper

@silySuper

Copy link
Copy Markdown

I need to verify that does the internal node whether support edit or not now?

@yanguoyu

yanguoyu commented Aug 30, 2023

Copy link
Copy Markdown
Contributor Author

I need to verify that does the internal node whether support edit or not now?

of course

@Keith-CY
Keith-CY added this pull request to the merge queue Aug 31, 2023
Merged via the queue into nervosnetwork:develop with commit 101b7e1 Aug 31, 2023
@yanguoyu
yanguoyu deleted the feat-network-default branch August 31, 2023 09:45
@Keith-CY Keith-CY mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants