fix: patch label of textfield when it's not a string - #2851
Merged
Conversation
Keith-CY
requested review from
FrederLu,
WhiteMinds,
devchenyan,
silySuper,
yanguoyu and
zhangyouxin
September 25, 2023 14:44
yanguoyu
approved these changes
Sep 25, 2023
WhiteMinds
approved these changes
Sep 26, 2023
| }: { | ||
| field: string | ||
| label?: string | ||
| label?: string | React.ReactNode |
Contributor
There was a problem hiding this comment.
Perhaps it could be implemented as label?: string | { node: ReactNode; text: string }
Contributor
Author
There was a problem hiding this comment.
Perhaps it could be implemented as
label?: string | { node: ReactNode; text: string }
I think label should be strictly limited to string, so the definition will be recovered to string, and if a pre-component is necessary, an independent field as prefix/suffix/preTab/postTab can be added
|
/package |
devchenyan
approved these changes
Sep 27, 2023
silySuper
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches the label of a textfield by a fallback that uses a field name. It should be fixed in the next release that
labelshould be limited to a string because it has its own semantic meaning.Before
After