Skip to content

ci: use key locker to sign neuron for windows - #2913

Merged
Keith-CY merged 3 commits into
developfrom
use-key-locker
Oct 30, 2023
Merged

ci: use key locker to sign neuron for windows#2913
Keith-CY merged 3 commits into
developfrom
use-key-locker

Conversation

@Keith-CY

@Keith-CY Keith-CY commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

@Keith-CY

This comment was marked as outdated.

Comment thread packages/neuron-wallet/scripts/customSign.js Outdated
@yanguoyu

Copy link
Copy Markdown
Contributor

How to skip the sign if these SM_XX secrets do not exist on the fork repo?

@Keith-CY

Copy link
Copy Markdown
Contributor Author

How to skip the sign if these SM_XX secrets do not exist on the fork repo?

Signing application failed won't block the workflow, e.g. https://github.com/nervosnetwork/neuron/actions/runs/6656736617/job/18089955073#step:13:132

@Keith-CY

Keith-CY commented Oct 27, 2023

Copy link
Copy Markdown
Contributor Author

How to skip the sign if these SM_XX secrets do not exist on the fork repo?

It does fail if SM_API_KEY is not set because authentication is required to download the smctl executable, fixed by 0abb497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants