Skip to content

fix: address input issue - #2918

Merged
devchenyan merged 2 commits into
nervosnetwork:developfrom
devchenyan:fix-issue_250
Nov 9, 2023
Merged

fix: address input issue#2918
devchenyan merged 2 commits into
nervosnetwork:developfrom
devchenyan:fix-issue_250

Conversation

@devchenyan

@devchenyan devchenyan commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

issue: Magickbase/neuron-public-issues#311

Screen-2023-11-06-153746.mp4

@Keith-CY

Keith-CY commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

The initial state is weird because text placeholder is not middle aligned, what if set row=2 when the input field is focused.

@Keith-CY

Keith-CY commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

The initial state is weird because text placeholder is not middle aligned, what if set row=2 when the input field is focused.

cc @devchenyan

@devchenyan

Copy link
Copy Markdown
Contributor Author

The initial state is weird because text placeholder is not middle aligned, what if set row=2 when the input field is focused.

cc @devchenyan

updated, please review

@devchenyan

Copy link
Copy Markdown
Contributor Author

please review @yanguoyu @Keith-CY

Comment thread packages/neuron-ui/src/widgets/TextField/index.tsx Outdated
Comment thread packages/neuron-ui/src/widgets/TextField/index.tsx
@devchenyan
devchenyan requested a review from Keith-CY November 9, 2023 05:40
@devchenyan

devchenyan commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 6808674929. @devchenyan

@devchenyan
devchenyan added this pull request to the merge queue Nov 9, 2023
Merged via the queue into nervosnetwork:develop with commit 5e33fe9 Nov 9, 2023
@devchenyan
devchenyan deleted the fix-issue_250 branch November 9, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants