Skip to content

feat: Unpack the app to app.asar for test mode. #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanguoyu merged 1 commit into from
Dec 19, 2023
Merged

feat: Unpack the app to app.asar for test mode. #2933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/package_for_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@ jobs:
env:
CI: false

- name: Write electron-build Test yml
uses: actions/github-script@v6
with:
script: |
const fs = require('node:fs')
const ympPath = 'packages/neuron-wallet/electron-builder.yml'
fs.writeFileSync(ympPath, fs.readFileSync(ympPath).toString().replace('asar: true', 'asar: false'))
Comment thread
homura marked this conversation as resolved.

- name: Package for MacOS
if: ${{ matrix.os == 'macos-latest' && env.MAC_SHOULD_CODE_SIGN == 'true' }}
run: |
Expand All @@ -122,6 +130,7 @@ jobs:
CSC_LINK: ${{ secrets.MAC_CERTIFICATE_BASE64 }}
CSC_KEY_PASSWORD: ${{ secrets.MAC_CERTIFICATE_PASSWORD }}
TEAM_ID: ${{ secrets.TEAM_ID }}
USE_HARD_LINKS: false
Comment thread
Keith-CY marked this conversation as resolved.

- name: Package for MacOS for skip code sign
if: ${{ matrix.os == 'macos-latest' && env.MAC_SHOULD_CODE_SIGN == 'false' }}
Expand All @@ -132,6 +141,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SKIP_NOTARIZE: true
USE_HARD_LINKS: false

- name: Package for Windows
if: matrix.os == 'windows-2019'
Expand All @@ -150,6 +160,7 @@ jobs:
yarn package:test linux
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
USE_HARD_LINKS: false

- name: Upload Neuron App Zip
if: matrix.os == 'macos-latest'
Expand Down
1 change: 1 addition & 0 deletions packages/neuron-wallet/electron-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ appId: com.nervos.neuron
copyright: Copyright (C) 2019-2023 Nervos Foundation.
productName: Neuron

# This property will replace to false in package for test action
asar: true

directories:
Expand Down