Skip to content

fix: It's unnecessary to use process.exit to skip create PR. #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanguoyu merged 1 commit into from
Nov 20, 2023
Merged

fix: It's unnecessary to use process.exit to skip create PR. #2947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update_ckb_client_versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
id: update_versions
run: |
npm run update:client-versions
git add .ckb-version .ckb-light-version
git add .ckb-version .ckb-light-version compatible.json

- name: Set GPG
uses: crazy-max/ghaction-import-gpg@v5
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/update_neuron_compatible.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
git add compatible.json

- name: Set GPG
if: ${{ success() }}
uses: crazy-max/ghaction-import-gpg@v5
with:
gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
Expand All @@ -40,7 +39,6 @@ jobs:
git_commit_gpgsign: true

- name: Open PR to RC branch
if: ${{ success() }}
uses: peter-evans/create-pull-request@v5
with:
title: Update Neuron compatibility table
Expand Down
2 changes: 1 addition & 1 deletion compatible.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@
"light": []
}
}
}
}
2 changes: 0 additions & 2 deletions scripts/add-neuron-version-in-compatibility-table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ const exec = () => {
if (newNeuronVersion && lastNeuronVersion !== newNeuronVersion) {
info.compatible[newNeuronVersion] = info.compatible[lastNeuronVersion]
fs.writeFileSync(compatiblePath, `${JSON.stringify(info, null, 2)}\r\n`)
} else {
process.exit(1)
}
}

Expand Down