Skip to content

feat: Support use sent cell when send CKB - #2963

Merged
Keith-CY merged 1 commit into
nervosnetwork:developfrom
yanguoyu:feat-chain-tx
Dec 21, 2023
Merged

feat: Support use sent cell when send CKB#2963
Keith-CY merged 1 commit into
nervosnetwork:developfrom
yanguoyu:feat-chain-tx

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

Refer to Magickbase/neuron-public-issues#217
After broading a tx successfully, disconnect the network, and then the cell status will always be sent.

user-sent-cell.mov

@Keith-CY

Copy link
Copy Markdown
Contributor

What does then the cell will always be spent. mean

@yanguoyu

Copy link
Copy Markdown
Contributor Author

What does then the cell will always be spent. mean

I mean how to let the cell keep sent status when testing this, because the local network disconnected, the local database cell's status will not updated.

@Keith-CY

Copy link
Copy Markdown
Contributor

What does then the cell will always be spent. mean

I mean how to let the cell keep sent status when testing this, because the local network disconnected, the local database cell's status will not updated.

Got it

Comment thread packages/neuron-wallet/src/services/tx/transaction-generator.ts
Comment thread packages/neuron-ui/src/components/Send/hooks.ts
Comment thread packages/neuron-ui/src/locales/en.json Outdated
Comment thread packages/neuron-ui/src/locales/zh.json Outdated
Comment thread packages/neuron-wallet/src/services/cells.ts
@silySuper

silySuper commented Dec 8, 2023

Copy link
Copy Markdown

/package
Packaging for test is done in 7136478750. @silySuper

Comment thread packages/neuron-ui/src/locales/zh-tw.json Outdated
Comment thread packages/neuron-ui/src/locales/zh.json Outdated
Comment thread packages/neuron-wallet/src/services/cells.ts
@Keith-CY

Copy link
Copy Markdown
Contributor

Please have a review @homura @WhiteMinds @devchenyan @zhangyouxin

@silySuper

silySuper commented Dec 19, 2023

Copy link
Copy Markdown

/package
Packaging for test is done in 7259382032. @silySuper

@silySuper

Copy link
Copy Markdown

1.When window size is small,UI shows abnormal.
截屏2023-12-20 10 04 18

2.In full node mode,sync shows failed.I want to check function in full node mode,how to solve this problem?
截屏2023-12-20 10 39 46

debug document:
neuron_debug_1703039822849.zip

@yanguoyu

Copy link
Copy Markdown
Contributor Author

2.In full node mode,sync shows failed.I want to check function in full node mode,how to solve this problem?

The reason is that you select the external node, but may be you don't start an external node. The selected network name is default node, but not Internal Node

[2023-12-20T02:36:28.622Z] [info]  Network:	switched to: {
  id: 'c65da1b2-7f9c-4ab9-9f36-65fe00afd168',
  name: 'default node',
  remote: 'http://127.0.0.1:8114',
  type: 1,
  genesisHash: '0x10639e0895502b5688a6be8cf69460d76541bfa4821629d86d62ba0aae3f9606',
  chain: 'ckb_testnet',
  readonly: false
} false
[2023-12-20T02:36:28.625Z] [info]  CKB:	external RPC on default uri detected, skip starting bundled CKB node.
[2023-12-20T02:36:29.147Z] [info]  Checking for update
[2023-12-20T02:36:29.168Z] [info]  CKB:	start verify external ckb node
[2023-12-20T02:36:29.173Z] [warn]  function call error: TypeError: fetch failed, retry 2 ...
[2023-12-20T02:36:29.317Z] [warn]  function call error: TypeError: fetch failed, retry 3 ...

@yanguoyu

Copy link
Copy Markdown
Contributor Author

1.When window size is small,UI shows abnormal.

Fixed 1150fda

@silySuper

Copy link
Copy Markdown

2.In full node mode,sync shows failed.I want to check function in full node mode,how to solve this problem?

The reason is that you select the external node, but may be you don't start an external node. The selected network name is default node, but not Internal Node

[2023-12-20T02:36:28.622Z] [info]  Network:	switched to: {
  id: 'c65da1b2-7f9c-4ab9-9f36-65fe00afd168',
  name: 'default node',
  remote: 'http://127.0.0.1:8114',
  type: 1,
  genesisHash: '0x10639e0895502b5688a6be8cf69460d76541bfa4821629d86d62ba0aae3f9606',
  chain: 'ckb_testnet',
  readonly: false
} false
[2023-12-20T02:36:28.625Z] [info]  CKB:	external RPC on default uri detected, skip starting bundled CKB node.
[2023-12-20T02:36:29.147Z] [info]  Checking for update
[2023-12-20T02:36:29.168Z] [info]  CKB:	start verify external ckb node
[2023-12-20T02:36:29.173Z] [warn]  function call error: TypeError: fetch failed, retry 2 ...
[2023-12-20T02:36:29.317Z] [warn]  function call error: TypeError: fetch failed, retry 3 ...

I only chose a default node which address is same to internal node.
截屏2023-12-21 09 38 33
,how to solve this problem?

@silySuper

silySuper commented Dec 21, 2023

Copy link
Copy Markdown

/package
Packaging for test is done in 7282993738. @silySuper

@yanguoyu

yanguoyu commented Dec 21, 2023

Copy link
Copy Markdown
Contributor Author

,how to solve this problem?

Start an external ckb node or select Internal node will resolve it.

@silySuper

Copy link
Copy Markdown

,how to solve this problem?

Start an external ckb node or select Internal node will resolve it.

Above operation is happend when external ckb node is started always. I remembered that if there is a function that when the address between external and internal node is same ,there will be a tip to help user which to use in history.But in this version https://github.com/nervosnetwork/neuron/actions/runs/7259382032 I can not see this function.Why?
截屏2023-12-21 09 59 10

@yanguoyu

Copy link
Copy Markdown
Contributor Author

,how to solve this problem?

Start an external ckb node or select Internal node will resolve it.

Above operation is happend when external ckb node is started always. I remembered that if there is a function that when the address between external and internal node is same ,there will be a tip to help user which to use in history.But in this version https://github.com/nervosnetwork/neuron/actions/runs/7259382032 I can not see this function.Why? 截屏2023-12-21 09 59 10

Sorry, I can not get your point.
The logic is:
If you start an external node but select Internal node, Neuron will notify you that create an external network or ignore the external node, but if you select an external network, you must start an external node, there are no tips.

@silySuper

silySuper commented Dec 21, 2023

Copy link
Copy Markdown

/package
Packaging for test is done in 7283165987. @silySuper

@Keith-CY
Keith-CY merged commit 94302cb into nervosnetwork:develop Dec 21, 2023
@yanguoyu
yanguoyu deleted the feat-chain-tx branch December 21, 2023 09:16
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@Keith-CY Keith-CY mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants