Skip to content

feat: Optimize the setting of sync start block in light client mode. - #2994

Merged
yanguoyu merged 1 commit into
nervosnetwork:developfrom
yanguoyu:feat-opt-start-block
Jan 17, 2024
Merged

feat: Optimize the setting of sync start block in light client mode.#2994
yanguoyu merged 1 commit into
nervosnetwork:developfrom
yanguoyu:feat-opt-start-block

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

Refer to Magickbase/neuron-public-issues#304.

  1. Show the last setted start block number
image
  1. If the current set start block number is less than before
image
  1. If the current set start block number is bigger than the header tip block number
image

@yanguoyu yanguoyu mentioned this pull request Dec 20, 2023
Closed
@yanguoyu
yanguoyu force-pushed the feat-opt-start-block branch from cb6cf7f to 2d736d6 Compare December 20, 2023 08:45
@Keith-CY

Keith-CY commented Dec 28, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

/package
Packaging for test is done in 7345589503. @Keith-CY

Keith-CY
Keith-CY reviewed Dec 28, 2023
View reviewed changes
Comment thread packages/neuron-ui/src/locales/zh.json Outdated
Comment thread packages/neuron-ui/src/components/PageContainer/hooks.ts Outdated
Comment thread packages/neuron-ui/src/components/PageContainer/hooks.ts Outdated
Comment thread packages/neuron-ui/src/components/PageContainer/hooks.ts Outdated
Comment thread packages/neuron-ui/src/components/PageContainer/hooks.ts Outdated
Comment thread packages/neuron-ui/src/types/Controller/index.d.ts Outdated
@Keith-CY

Keith-CY commented Dec 28, 2023

Copy link
Copy Markdown
Contributor

Please have a review @homura @WhiteMinds @devchenyan @zhangyouxin

@Keith-CY
Keith-CY requested a review from zhangyouxin December 28, 2023 08:11
@Keith-CY

Keith-CY commented Dec 29, 2023

Copy link
Copy Markdown
Contributor

Please have a review @homura @WhiteMinds @devchenyan @zhangyouxin

@yanguoyu
yanguoyu force-pushed the feat-opt-start-block branch from 5aeb981 to 2acaf02 Compare December 29, 2023 04:34
homura
homura reviewed Dec 29, 2023
View reviewed changes
Comment thread packages/neuron-ui/src/components/PageContainer/index.tsx Outdated
Comment thread packages/neuron-ui/src/components/PageContainer/hooks.ts Outdated
@yanguoyu
yanguoyu force-pushed the feat-opt-start-block branch from 2acaf02 to a9cfc82 Compare December 29, 2023 10:41
@Keith-CY Keith-CY mentioned this pull request Dec 31, 2023
Closed
@yanguoyu
yanguoyu force-pushed the feat-opt-start-block branch from a9cfc82 to 877d539 Compare January 2, 2024 01:51
@yanguoyu
yanguoyu requested a review from Keith-CY January 9, 2024 10:44
@yanguoyu
yanguoyu force-pushed the feat-opt-start-block branch from 3dbbf4e to f7bef5b Compare January 10, 2024 02:27
Keith-CY
Keith-CY reviewed Jan 11, 2024
View reviewed changes
Comment thread packages/neuron-ui/src/components/PageContainer/hooks.ts Outdated
Comment thread packages/neuron-ui/src/locales/en.json Outdated
Comment thread packages/neuron-ui/src/locales/en.json Outdated
Comment thread packages/neuron-ui/src/locales/en.json
Comment thread packages/neuron-wallet/src/controllers/api.ts Outdated
@yanguoyu
yanguoyu force-pushed the feat-opt-start-block branch 2 times, most recently from 6a2b12f to 3f40ccc Compare January 12, 2024 08:54
@yanguoyu

yanguoyu commented Jan 16, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/package
Packageing failed in 7535904224. @yanguoyu

Keith-CY
Keith-CY approved these changes Jan 16, 2024
View reviewed changes
Comment thread packages/neuron-ui/src/components/PageContainer/hooks.ts
@yanguoyu
yanguoyu force-pushed the feat-opt-start-block branch from 3f40ccc to 6ebc225 Compare January 16, 2024 06:37
@yanguoyu

yanguoyu commented Jan 16, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 7537937385. @yanguoyu

@yanguoyu
yanguoyu force-pushed the feat-opt-start-block branch from 6ebc225 to 2b05e94 Compare January 17, 2024 00:35
@yanguoyu

yanguoyu commented Jan 17, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 7549357935. @yanguoyu

@yanguoyu
yanguoyu enabled auto-merge January 17, 2024 07:50
@yanguoyu
yanguoyu added this pull request to the merge queue Jan 17, 2024
Merged via the queue into nervosnetwork:develop with commit ae34b2b Jan 17, 2024
@yanguoyu
yanguoyu deleted the feat-opt-start-block branch January 17, 2024 08:47
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@yanguoyu
feat: Optimize the setting of sync start block in light client mode. (n…
c521664 
…ervosnetwork#2994)
@Keith-CY Keith-CY mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WhiteMinds WhiteMinds Awaiting requested review from WhiteMinds
@FrederLu FrederLu Awaiting requested review from FrederLu
@zhangyouxin zhangyouxin Awaiting requested review from zhangyouxin
4 more reviewers
@Keith-CY Keith-CY Keith-CY approved these changes
@homura homura homura approved these changes
@devchenyan devchenyan devchenyan approved these changes
@silySuper silySuper silySuper approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yanguoyu @Keith-CY @homura @devchenyan @silySuper