Skip to content

fix: Remove walletId for get-multisig-config API - #3010

Merged
Keith-CY merged 1 commit into
nervosnetwork:developfrom
yanguoyu:fix-multisig
Jan 17, 2024
Merged

fix: Remove walletId for get-multisig-config API#3010
Keith-CY merged 1 commit into
nervosnetwork:developfrom
yanguoyu:fix-multisig

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

Refer to Magickbase/neuron-public-issues#348

  1. Remove walletId for get-multisig-config API
  2. Disabled Approve button when the current wallet can not sign for the multisig config.
multisig.mov

Comment thread packages/neuron-wallet/src/services/sync-progress.ts
Comment thread packages/neuron-ui/src/components/MultisigAddress/index.tsx
@yanguoyu

yanguoyu commented Jan 8, 2024

Copy link
Copy Markdown
Contributor Author

/package
Packageing failed in 7442809819. @yanguoyu

@silySuper

silySuper commented Jan 12, 2024

Copy link
Copy Markdown

/package
Packaging for test is done in 7499517505. @silySuper

@silySuper

silySuper commented Jan 16, 2024

Copy link
Copy Markdown

After switching different wallets for several times,sync process is stoped,even I have exited and open app again.

2024-01-16.10.21.14.mov

@yanguoyu

yanguoyu commented Jan 16, 2024

Copy link
Copy Markdown
Contributor Author

After switching different wallets for several times,sync process is stoped,even I have exited and open app again.

2024-01-16.10.21.14.mov
Uploading neuron_debug_1705371474620.zip…

Does the multisig sync to 99.95% block height? If not, it's normal because the light client should wait for the least sync block number.
And We will optimate the multisig sync, then the multisig address also supports setting the start block number.

@silySuper

Copy link
Copy Markdown

This is multisig sync,already to 99.95% block height
截屏2024-01-16 10 28 21

@yanguoyu

Copy link
Copy Markdown
Contributor Author

This is multisig sync,already to 99.95% block height 截屏2024-01-16 10 28 21

Thanks, I will find out what happened, besides, the debug information does not upload success in the up comment.

@silySuper

Copy link
Copy Markdown
截屏2024-01-16 10 32 34 debug log shows this ,does this affect?

neuron_debug_1705372285343.zip

1. Remove walletId for `get-multisig-config` API
2. Disabled `Approve` button when the current wallet can not sign for the multisig config.
@yanguoyu

yanguoyu commented Jan 17, 2024

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 7549292195. @yanguoyu

@Keith-CY
Keith-CY merged commit 7fe4b4d into nervosnetwork:develop Jan 17, 2024
@yanguoyu
yanguoyu deleted the fix-multisig branch January 17, 2024 06:52
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@Keith-CY Keith-CY mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants