fix: Remove walletId for get-multisig-config API - #3010
Merged
Conversation
yanguoyu
requested review from
FrederLu,
Keith-CY,
WhiteMinds,
devchenyan,
homura and
silySuper
January 4, 2024 08:36
devchenyan
approved these changes
Jan 5, 2024
Keith-CY
reviewed
Jan 7, 2024
Keith-CY
approved these changes
Jan 7, 2024
Contributor
Author
|
/package |
|
/package |
|
After switching different wallets for several times,sync process is stoped,even I have exited and open app again. 2024-01-16.10.21.14.mov |
Contributor
Author
Does the multisig sync to 99.95% block height? If not, it's normal because the light client should wait for the least sync block number. |
Contributor
Author
yanguoyu
force-pushed
the
fix-multisig
branch
from
January 17, 2024 00:28
1b6598c to
c7c9555
Compare
1. Remove walletId for `get-multisig-config` API 2. Disabled `Approve` button when the current wallet can not sign for the multisig config.
yanguoyu
force-pushed
the
fix-multisig
branch
from
January 17, 2024 00:30
57d0150 to
a28570b
Compare
Contributor
Author
|
/package |
silySuper
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Refer to Magickbase/neuron-public-issues#348
walletIdforget-multisig-configAPIApprovebutton when the current wallet can not sign for the multisig config.multisig.mov