Skip to content

Adds Spanish 'es' translation for wallet and UI functions - #3024

Merged
Keith-CY merged 132 commits into
nervosnetwork:developfrom
Natixe:develop
Jan 17, 2024
Merged

Adds Spanish 'es' translation for wallet and UI functions#3024
Keith-CY merged 132 commits into
nervosnetwork:developfrom
Natixe:develop

Conversation

@Natixe

@Natixe Natixe commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@Natixe

Natixe commented Jan 12, 2024

Copy link
Copy Markdown
Contributor Author

I haven't finished translating everything yet 👌

@Keith-CY

Keith-CY commented Jan 13, 2024

Copy link
Copy Markdown
Contributor

I haven't finished translating everything yet 👌

Hi @Natixe
An open PR can be converted into a draft one when it's WIP
image
And it can be ready for review once everything is set.

Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
@Natixe

Natixe commented Jan 13, 2024

Copy link
Copy Markdown
Contributor Author

Hey @Keith-CY
Thank you for your feedback as always they are great!
How do I convert it to WIP then?

Natixe and others added 4 commits January 13, 2024 18:35
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Comment thread packages/neuron-wallet/src/locales/es.ts Outdated
Comment thread packages/neuron-wallet/src/locales/es.ts Outdated
Comment thread packages/neuron-wallet/src/locales/es.ts Outdated
Comment thread packages/neuron-wallet/src/locales/es.ts Outdated
Comment thread packages/neuron-wallet/src/locales/es.ts Outdated
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Natixe and others added 7 commits January 14, 2024 01:02
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Comment thread packages/neuron-ui/src/locales/es.json Outdated
Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Comment thread packages/neuron-ui/src/locales/en.json Outdated
@Keith-CY

Copy link
Copy Markdown
Contributor

Hey @Keith-CY Thank you for your feedback as always they are great! How do I convert it to WIP then?

Sorry for replying late.

Convert to draft sits beneath the reviewer list.

image

@Natixe

Natixe commented Jan 14, 2024

Copy link
Copy Markdown
Contributor Author

Haaa ok thanks a lot now I'll be but since the translation is finally finished I don't need it anymore for next time I'll use it !

@Natixe
Natixe requested a review from Keith-CY January 15, 2024 23:09
@Keith-CY

Keith-CY commented Jan 16, 2024

Copy link
Copy Markdown
Contributor

/package
Packaging for test is done in 7537842407. @Keith-CY

@Keith-CY

Copy link
Copy Markdown
Contributor

I've verified the functions, thank you @Natixe for your enthusiastic efforts.

@Keith-CY
Keith-CY merged commit adf593d into nervosnetwork:develop Jan 17, 2024
yanguoyu pushed a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
…ork#3024)

Co-authored-by: alejandroRbit <94946624+alejandroRbit@users.noreply.github.com>
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
@Keith-CY Keith-CY mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants