Skip to content

fix: The first sync only stuck full ckb node start. #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keith-CY merged 1 commit into from
Mar 15, 2024
Merged

fix: The first sync only stuck full ckb node start. #3081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/neuron-wallet/src/services/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ class NodeService {
await stopMonitor('ckb')
const isDefaultCKBNeedStart = await this.isDefaultCKBNeedRestart()
if (isDefaultCKBNeedStart) {
if (SettingsService.getInstance().isFirstSync) {
const currentNetwork = NetworksService.getInstance().getCurrent()
if (SettingsService.getInstance().isFirstSync && currentNetwork.type === NetworkType.Default) {
logger.info("CKB:\tThis is the first sync, please wait for the user's confirmation")
return
}
Expand Down
2 changes: 1 addition & 1 deletion packages/neuron-wallet/tests/services/node.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ describe('NodeService', () => {
describe('test start default node', () => {
beforeEach(() => {
const NodeService = require('../../src/services/node').default
stubbedNetworsServiceGet.mockReturnValue({ remote: BUNDLED_CKB_URL, readonly: true })
stubbedNetworsServiceGet.mockReturnValue({ remote: BUNDLED_CKB_URL, readonly: true, type: 0 })
getLocalNodeInfoMock.mockRejectedValue('not start')
nodeService = new NodeService()
})
Expand Down