Skip to content

feat: Add tooltip/title so function of icon buttons will be clear #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devchenyan merged 1 commit into from
Jun 6, 2024
Merged

feat: Add tooltip/title so function of icon buttons will be clear #3154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/neuron-ui/src/components/CellManagement/cellManagement.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,14 @@
}

.actions {
display: flex;
gap: 16px;
& > svg {
cursor: pointer;
&[data-disabled='true'] {
cursor: not-allowed;
opacity: 50%;
}
margin-right: 16px;
}
}

Expand Down
44 changes: 26 additions & 18 deletions packages/neuron-ui/src/components/CellManagement/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,28 +186,36 @@ const getColumns = ({
const { locked, lockedReason } = item
return (
<div className={styles.actions}>
<DetailIcon onClick={onAction} data-action={Actions.View} data-index={index} />
<Tooltip tip={t('history.detail')} showTriangle placement="top">
<DetailIcon onClick={onAction} data-action={Actions.View} data-index={index} />
</Tooltip>
{locked ? (
<UnLock
data-disabled={!!lockedReason}
onClick={onAction}
data-action={Actions.Unlock}
data-index={index}
/>
<Tooltip tip={t('cell-manage.unlock')} showTriangle placement="top">
<UnLock
data-disabled={!!lockedReason}
onClick={onAction}
data-action={Actions.Unlock}
data-index={index}
/>
</Tooltip>
) : (
<LockCell
data-disabled={!!lockedReason}
onClick={onAction}
data-action={Actions.Lock}
<Tooltip tip={t('cell-manage.lock')} showTriangle placement="top">
<LockCell
data-disabled={!!lockedReason}
onClick={onAction}
data-action={Actions.Lock}
data-index={index}
/>
</Tooltip>
)}
<Tooltip tip={t('cell-manage.consume')} showTriangle placement="top">
<Consume
data-disabled={!!locked}
onClick={locked ? undefined : onAction}
data-action={Actions.Consume}
data-index={index}
/>
)}
<Consume
data-disabled={!!locked}
onClick={locked ? undefined : onAction}
data-action={Actions.Consume}
data-index={index}
/>
</Tooltip>
</div>
)
},
Expand Down