Skip to content

feat: Add guide for multisig address - #3194

Merged
Keith-CY merged 2 commits into
nervosnetwork:developfrom
yanguoyu:feat-multi-guide
Jun 25, 2024
Merged

feat: Add guide for multisig address#3194
Keith-CY merged 2 commits into
nervosnetwork:developfrom
yanguoyu:feat-multi-guide

Conversation

@yanguoyu

Copy link
Copy Markdown
Contributor

Refer to Magickbase/neuron-public-issues#401

2024-06-20.18.04.41.mov

Comment thread packages/neuron-ui/src/components/MultisigAddress/index.tsx Outdated
Comment thread packages/neuron-ui/src/components/MultisigAddress/index.tsx Outdated
Comment thread packages/neuron-ui/src/widgets/Tooltip/index.tsx Outdated
@Danie0918

Copy link
Copy Markdown

@twhy @homura @devchenyan Please have a review.

Comment thread packages/neuron-ui/src/locales/en.json Outdated
@silySuper

silySuper commented Jun 24, 2024

Copy link
Copy Markdown

/package
Packaging for test is done in 9638580208. @silySuper

@silySuper

Copy link
Copy Markdown

https://github.com/nervosnetwork/neuron/actions/runs/9638580208 this package can not save lanuage as setting correctly.so some language can not see.

2024-06-24.16.52.21.mov

@yanguoyu

yanguoyu commented Jun 24, 2024

Copy link
Copy Markdown
Contributor Author

https://github.com/nervosnetwork/neuron/actions/runs/9638580208 this package can not save lanuage as setting correctly.so some language can not see.

2024-06-24.16.52.21.mov

I guess the language will take effect after restart the Neuron

@Keith-CY

Keith-CY commented Jun 24, 2024

Copy link
Copy Markdown
Contributor

nervosnetwork/neuron/actions/runs/9638580208 this package can not save lanuage as setting correctly.so some language can not see.
2024-06-24.16.52.21.mov

I guess the language will take effect after restart the Neuron

Only Chinese/Chinese Simplified are not rendered instantly, other languages are switched as expected in the video


Correct myself, the first time switch to French worked well, other actions didn't

@silySuper

Copy link
Copy Markdown

https://github.com/nervosnetwork/neuron/actions/runs/9638580208 this package can not save lanuage as setting correctly.so some language can not see.
2024-06-24.16.52.21.mov

I guess the language will take effect after restart the Neuron

I found that when I change language and click apply ,the setting can not change.If it changed,language will effect.Does the language change data saved correctly in database after clicking apply button?When restart,it changed.

@silySuper

silySuper commented Jun 25, 2024

Copy link
Copy Markdown

Neuron (view)
fix the problem related to this issue

@Keith-CY
Keith-CY merged commit 878da3c into nervosnetwork:develop Jun 25, 2024
@yanguoyu
yanguoyu deleted the feat-multi-guide branch June 25, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants