Skip to content

feat: Support XUDT - #3206

Merged
Keith-CY merged 4 commits into
nervosnetwork:developfrom
yanguoyu:feat-support-xudt
Jul 19, 2024
Merged

feat: Support XUDT#3206
Keith-CY merged 4 commits into
nervosnetwork:developfrom
yanguoyu:feat-support-xudt

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

Refer to Magickbase/neuron-public-issues#379

Magickbase/neuron-public-issues#379 (comment) is the test list

Asset Account:

2024-07-09.17.26.02.mov

Customized Assets:

2024-07-09.17.41.15.mov

History, Overview And CellManage:

2024-07-09.17.45.46.mov

@Danie0918

Copy link
Copy Markdown

@devchenyan @homura Please have a review.

Comment thread packages/neuron-ui/src/components/CellManagement/hooks.ts
Comment thread packages/neuron-ui/src/utils/is.ts
@yanguoyu
yanguoyu force-pushed the feat-support-xudt branch from 9e7263f to 83c0abc Compare July 11, 2024 09:19
@silySuper

silySuper commented Jul 12, 2024

Copy link
Copy Markdown

/package
Packaging for test is done in 9904035698. @silySuper

@Keith-CY

Copy link
Copy Markdown
Contributor

@homura please check

@yanguoyu
yanguoyu force-pushed the feat-support-xudt branch from f62d336 to 189e257 Compare July 16, 2024 00:27
@silySuper

Copy link
Copy Markdown

I have known that xudt does not have tool like this https://ckb.tools/sudt,so it will try to use code to edit and transfer xudt.

@yanguoyu
yanguoyu force-pushed the feat-support-xudt branch from 189e257 to 066860d Compare July 17, 2024 06:37
@yanguoyu
yanguoyu force-pushed the feat-support-xudt branch from 066860d to 3c7b7b9 Compare July 17, 2024 06:46
@silySuper

Copy link
Copy Markdown

1.In history page,when I received 1,000 XTT21 https://pudge.explorer.nervos.org/transaction/0x57132e618c65a2c665ee72b199c2804c0379eefb8885a3c6e8028a614e1549f9?layout=lite
neuron asset shows --(both in overview page):
截屏2024-07-17 15 07 19
截屏2024-07-17 15 50 46

Does here need show ckb asset? @Danie0918

In customized asset,asset shows 100000000000(has no unit) ,Does asset not show 1000?@Danie0918
截屏2024-07-17 15 38 20
In asset account ,it shows:

截屏2024-07-17 15 40 53

when I want to change account info,it can not confirm.

截屏2024-07-17 15 43 02

@yanguoyu

Copy link
Copy Markdown
Contributor Author

@silySuper Before you update the asset info, Neuron doesn't know the token information. So it can only show the full mount without decimal. After the token information is updated, it will show normal.

Under normal circumstances, token information can be saved correctly. Could you describe the reproducible steps for the inability to edit?

image

@yanguoyu

yanguoyu commented Jul 18, 2024

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 9986095976. @yanguoyu

@silySuper

Copy link
Copy Markdown

2.Send xudt from another wallet(wallet 9 ---> test01 xudt account address),UI choose is only one ,and when click send shows an error.
截屏2024-07-19 10 49 16
截屏2024-07-19 10 50 00

@yanguoyu

Copy link
Copy Markdown
Contributor Author

2.Send xudt from another wallet(wallet 9 ---> test01 xudt account address),UI choose is only one ,and when click send shows an error. 截屏2024-07-19 10 49 16 截屏2024-07-19 10 50 00

Because the address that you sent to is not a secp256k1 address, it does not support sending with the cheque lock. Could you paste the send address and upload the log?

@silySuper

silySuper commented Jul 19, 2024

Copy link
Copy Markdown

2.Send xudt from another wallet(wallet 9 ---> test01 xudt account address),UI choose is only one ,and when click send shows an error. 截屏2024-07-19 10 49 16 截屏2024-07-19 10 50 00

Because the address that you sent to is not a secp256k1 address, it does not support sending with the cheque lock. Could you paste the send address and upload the log?

address is:
ckt1qq6pngwqn6e9vlm92th84rk0l4jp2h8lurchjmnwv8kq3rt5psf4vq0hmqz5aayuhd5ar23wyn3ncstacrs07wc3e4hzz
截屏2024-07-19 11 29 51

log:
neuron_debug_1721359955322.zip

@yanguoyu

yanguoyu commented Jul 19, 2024

Copy link
Copy Markdown
Contributor Author

ckt1qq6pngwqn6e9vlm92th84rk0l4jp2h8lurchjmnwv8kq3rt5psf4vq0hmqz5aayuhd5ar23wyn3ncstacrs07wc3e4hzz

fixed

@yanguoyu

yanguoyu commented Jul 19, 2024

Copy link
Copy Markdown
Contributor Author

/package
Packaging for test is done in 10002875485. @yanguoyu

@silySuper

Copy link
Copy Markdown

3.Sudt send to xudt address (ckt1qq6pngwqn6e9vlm92th84rk0l4jp2h8lurchjmnwv8kq3rt5psf4vqvz8rmuhallzq490rp2xk3fl29vhyzmngq9ej7sm), .After send success sudt asset is decreased,but xudt does not increase.

2024-07-19.15.38.20.mov

@yanguoyu

Copy link
Copy Markdown
Contributor Author

3.Sudt send to xudt address (ckt1qq6pngwqn6e9vlm92th84rk0l4jp2h8lurchjmnwv8kq3rt5psf4vqvz8rmuhallzq490rp2xk3fl29vhyzmngq9ej7sm), .After send success sudt asset is decreased,but xudt does not increase.

2024-07-19.15.38.20.mov

I guess you have two sudt accounts for this address.
https://pudge.explorer.nervos.org/address/ckt1qq6pngwqn6e9vlm92th84rk0l4jp2h8lurchjmnwv8kq3rt5psf4vqvz8rmuhallzq490rp2xk3fl29vhyzmngq9ej7sm
From the explorer: 0x641238cd95b9f5e6224da1963a0bcaa2e972dc87e56eb1ded9a35dcebbc37ff4 only have 10011 amount.
And it has another sudt 0xb1718e7c0175d8a6428a6ddca708b765803e3131d07c8e0046a94be310f1722b with amount 320000
image

@silySuper

Copy link
Copy Markdown

1.verified 2.verified 3.not need to change

@Keith-CY
Keith-CY added this pull request to the merge queue Jul 19, 2024
Merged via the queue into nervosnetwork:develop with commit 2ec3ff8 Jul 19, 2024
@yanguoyu
yanguoyu deleted the feat-support-xudt branch July 19, 2024 08:38
@Keith-CY Keith-CY mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants