Conversation
homura
approved these changes
Mar 10, 2025
Keith-CY
approved these changes
Mar 10, 2025
Contributor
There was a problem hiding this comment.
PR Overview
The PR aims to improve the error handling for incorrect password scenarios during offline signing by introducing a dedicated exception.
- Import a new exception, IncorrectPassword, from the exceptions module.
- Add a check in the error handling logic to throw the new IncorrectPassword exception when the password is incorrect.
Reviewed Changes
| File | Description |
|---|---|
| packages/neuron-wallet/src/controllers/offline-sign.ts | Adds specific error handling for password errors by importing IncorrectPassword and checking for the error message |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
| result: signer.toJSON(), | ||
| } | ||
| } catch (err) { | ||
| if (err.message === 'Incorrect password!') { |
There was a problem hiding this comment.
Using a hard-coded string to check for an incorrect password may be brittle if the error message changes. Consider using a dedicated error code or property to reliably identify the error.
Suggested change
| if (err.message === 'Incorrect password!') { | |
| if (err.code === 'INCORRECT_PASSWORD') { |
|
/package |
silySuper
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: