refactor(neuron-ui): clean todo in neuron-ui

packages/neuron-ui/src/components/Receive/index.tsx

@@ -42,7 +42,6 @@ const Receive = (props: React.PropsWithoutRef<RouteComponentProps<{ address: str
   const accountAddress = params.address || receiving[0]
 
   if (!accountAddress) {
-    // TODO: better error handling
     return <div>{t('receive.address-not-found')}</div>
   }
 

packages/neuron-ui/src/components/Transaction/index.tsx

@@ -17,7 +17,6 @@ const Transaction = (props: React.PropsWithoutRef<ContentProps & RouteComponentP
   } = useNeuronWallet()
 
   useEffect(() => {
-    // TODO: verify hash
     dispatch(actionCreators.getTransaction(match.params.hash))
     return () => {
       providerDispatch({

packages/neuron-ui/src/components/WalletEditor/index.tsx

@@ -3,9 +3,10 @@ import { actionCreators } from 'containers/MainContent/reducer'
 import React, { useCallback, useEffect, useMemo } from 'react'
 import { Button, Card, Form } from 'react-bootstrap'
 import { useTranslation } from 'react-i18next'
-import { RouteComponentProps } from 'react-router-dom'
+import { RouteComponentProps, Link } from 'react-router-dom'
 import { useNeuronWallet } from 'utils/hooks'
 import InlineInput, { InputProps } from 'widgets/InlineInput'
+import { Routes } from 'utils/const'
 import { useAreParamsValid, useInputs, useToggleDialog, useWalletEditor } from './hooks'
 
 export default ({
@@ -22,8 +23,15 @@ export default ({
   const wallet = useMemo(() => wallets.find(w => w.id === id), [id, wallets])
 
   if (!wallet) {
-    // TODO: Better error handling
-    throw new Error('Wallet not found')
+    const label = `${t('siderbar.settings')}-${t('settings.setting-tabs.wallets')}`
+    return (
+      <div>
+        <p>{t('messages.wallet-is-not-found')}</p>
+        <Link to={Routes.SettingsWallets} className="btn btn-primary">
+          {label}
+        </Link>
+      </div>
+    )
   }
 
   const editor = useWalletEditor()

packages/neuron-ui/src/components/WalletWizard/index.tsx

@@ -83,8 +83,10 @@ const Mnemonic = ({
             payload: res,
           })
         })
-        // TODO: Better Error Handle
-        .catch(err => console.error(err))
+        .catch(err => {
+          console.error(err)
+          history.goBack()
+        })
     } else {
       dispatch({
         type: 'imported',

packages/neuron-ui/src/containers/MainContent/actionCreators/networks.ts

@@ -90,7 +90,6 @@ export default {
     }
   },
   setNetwork: (id: string) => {
-    // TODO: verification
     networksCall.activate(id)
     return {
       type: MainActions.Networks,

packages/neuron-ui/src/containers/Providers/hooks.ts

@@ -31,8 +31,10 @@ export const useChannelListeners = (i18n: any, chain: any, dispatch: React.Dispa
             })
           }
         } else {
-          // TODO: better prompt
+          /* eslint-disable no-alert */
+          // TODO: better prompt, prd required
           window.alert(i18n.t('messages.failed-to-initiate,-please-reopen-Neuron'))
+          /* eslint-enable no-alert */
           window.close()
         }
       },
@@ -49,8 +51,6 @@ export const useChannelListeners = (i18n: any, chain: any, dispatch: React.Dispa
             break
           }
         }
-      } else {
-        // TODO: handle error
       }
     })
 
@@ -75,8 +75,6 @@ export const useChannelListeners = (i18n: any, chain: any, dispatch: React.Dispa
             break
           }
         }
-      } else {
-        // TODO: handle error
       }
     })
 

packages/neuron-ui/src/locales/en.json

@@ -124,7 +124,8 @@
       "wallet-imported-successfully": "{{name}} imported successfully",
       "wallet-created-successfully": "{{name}} created successfully",
       "wallet-updated-successfully": "{{name}} updated successfully",
-      "protocol-is-required": "Protocol is required"
+      "protocol-is-required": "Protocol is required",
+      "wallet-is-not-found": "Wallet is not found"
     }
   }
 }

packages/neuron-ui/src/locales/zh.json

@@ -117,7 +117,8 @@
       "wallet-imported-successfully": "{{name}} 导入成功",
       "wallet-created-successfully": "{{name}} 创建成功",
       "wallet-updated-successfully": "{{name}} 更新成功",
-      "protocol-is-required": "请指定 URL 协议"
+      "protocol-is-required": "请指定 URL 协议",
+      "wallet-is-not-found": "未找到钱包"
     }
   }
 }

packages/neuron-ui/src/utils/validators.ts

@@ -1,8 +1,8 @@
 import { ADDRESS_LENGTH, MIN_PASSWORD_LENGTH, MAX_PASSWORD_LENGTH } from './const'
 
 export const verifyAddress = (address: string): boolean => {
-  // TODO: verify address
-  return address.replace(/^0x/, '').length === ADDRESS_LENGTH
+  // TODO: verify address, prd required
+  return address.length === ADDRESS_LENGTH
 }
 export const verifyWalletSubmission = ({
   password,