Keystore compatibility with cli - #898
Merged
Merged
Conversation
ashchan
force-pushed
the
keystore-compatibility-with-cli
branch
from
August 28, 2019 11:32
1213f88 to
7ea91f0
Compare
to reproduce the 060B50AC:digital envelope routines:EVP_PBE_scrypt:memory limit exceeded error
ashchan
marked this pull request as ready for review
August 28, 2019 13:24
Keith-CY
approved these changes
Aug 29, 2019
classicalliu
approved these changes
Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having two issues needing fix:
262144ofnparam), resulting OPENSSLMEMORY_LIMIT_EXCEEDEDerror.Worth noting
We don't aim 100% compatibility. CKB CLI uses the master private key to derive mainnet/testnet addresses. Neuron on the other hand generates HD addresses (both receiving and change) with full path (
m/44'/309'/0'/0/n, andm/44'/309'/0'/1/n).This means the address you see from cli will NOT appear in Neuron.
One more thing, our Keystore format doesn't conform to Ethereum wallets in the way that we save the encrypted extended master key, not the encrypted master private key.
To fix