[ᚬmaster] Rc/v0.19.0 beta.0

CHANGELOG.md

@@ -1,3 +1,33 @@
+# [0.19.0-beta.0](https://github.com/nervosnetwork/neuron/compare/v0.18.0-beta.1...v0.19.0-beta.0) (2019-08-29)
+
+### BREAKING CHANGES
+
+* Code signing certification was updated. Manual installation of this version is required as automatic update won't work.
+* There was a bug that caused the keystore mac to calculate incorrectly. Older exported keystore files might not be able to be imported.
+* DB structure was changed per CKB transaction and other types' changes.
+
+### Bug Fixes
+
+* Fix keystore mac calculation
+* add outputsData and headerDeps ([f2432eb](https://github.com/nervosnetwork/neuron/commit/f2432eb))
+* Error when handling crypto.scryptSync with N > 16384 ([eac4339](https://github.com/nervosnetwork/neuron/commit/eac4339))
+* fix filterOutputs for async filter ([c851963](https://github.com/nervosnetwork/neuron/commit/c851963))
+* hide some tests in lock utils tests ([19c6673](https://github.com/nervosnetwork/neuron/commit/19c6673))
+* remove default hash_type=data ([33cc4cf](https://github.com/nervosnetwork/neuron/commit/33cc4cf))
+
+
+### Features
+
+* bump sdk to v0.19.0 in neuron-ui ([3b6ede9](https://github.com/nervosnetwork/neuron/commit/3b6ede9))
+* bump sdk to v0.19.0 in neuron-wallet ([6ca8200](https://github.com/nervosnetwork/neuron/commit/6ca8200))
+* Increase KDF params N value to 2**18 to produce more secure keystore ([06f5ac6](https://github.com/nervosnetwork/neuron/commit/06f5ac6))
+* Remove MenuCommand enum ([#900](https://github.com/nervosnetwork/neuron/issues/900)) ([e40c5cf](https://github.com/nervosnetwork/neuron/commit/e40c5cf))
+* Update TypeScript to 3.6 ([ac61a5b](https://github.com/nervosnetwork/neuron/commit/ac61a5b))
+* **neuron-ui:** set the cycles to empty if the transaction is invalid ([64166cc](https://github.com/nervosnetwork/neuron/commit/64166cc))
+* **neuron-ui:** show confirmations on the History View ([84692c7](https://github.com/nervosnetwork/neuron/commit/84692c7))
+
+
+
 # [0.18.0-beta.1](https://github.com/nervosnetwork/neuron/compare/v0.18.0-beta.0...v0.18.0-beta.1) (2019-08-22)
 
 

lerna.json

@@ -2,7 +2,7 @@
   "packages": [
     "packages/*"
   ],
-  "version": "0.18.0-beta.1",
+  "version": "0.19.0-beta.0",
   "npmClient": "yarn",
   "useWorkspaces": true
 }

package.json

@@ -2,7 +2,7 @@
   "name": "neuron",
   "productName": "Neuron",
   "description": "CKB Neuron Wallet",
-  "version": "0.18.0-beta.1",
+  "version": "0.19.0-beta.0",
   "private": true,
   "author": {
     "name": "Nervos Core Dev",
@@ -44,8 +44,8 @@
   },
   "devDependencies": {
     "@types/jest": "24.0.13",
-    "@typescript-eslint/eslint-plugin": "1.10.2",
-    "@typescript-eslint/parser": "1.10.2",
+    "@typescript-eslint/eslint-plugin": "2.0.0",
+    "@typescript-eslint/parser": "2.0.0",
     "concurrently": "4.1.1",
     "cross-env": "5.2.0",
     "eslint": "5.16.0",
@@ -61,7 +61,7 @@
     "nodemon": "1.19.1",
     "prettier": "1.17.1",
     "ts-jest": "24.0.2",
-    "typescript": "3.5.3",
+    "typescript": "3.6.2",
     "wait-on": "3.3.0"
   },
   "dependencies": {}

packages/neuron-ui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "neuron-ui",
-  "version": "0.18.0-beta.1",
+  "version": "0.19.0-beta.0",
   "private": true,
   "author": {
     "name": "Nervos Core Dev",
@@ -43,7 +43,7 @@
     "last 2 chrome versions"
   ],
   "dependencies": {
-    "@nervosnetwork/ckb-sdk-core": "0.18.0",
+    "@nervosnetwork/ckb-sdk-core": "0.19.0",
     "@uifabric/experiments": "7.10.0",
     "@uifabric/styling": "7.4.0",
     "canvg": "2.0.0",

packages/neuron-ui/src/components/History/index.tsx

@@ -13,10 +13,12 @@ import { useSearch } from './hooks'
 
 const History = ({
   app: {
+    tipBlockNumber: chainBlockNumber,
     loadings: { transactionList: isLoading, updateDescription: isUpdatingDescription },
   },
   wallet: { id },
   chain: {
+    tipBlockNumber: syncedBlockNumber,
     transactions: { pageNo = 1, pageSize = 15, totalCount = 0, items = [] },
   },
   history,
@@ -33,6 +35,10 @@ const History = ({
   }, [id, history])
   const onSearch = useCallback(() => history.push(`${Routes.History}?keywords=${keywords}`), [history, keywords])
 
+  const tipBlockNumber = useMemo(() => {
+    return Math.max(+syncedBlockNumber, +chainBlockNumber).toString()
+  }, [syncedBlockNumber, chainBlockNumber])
+
   const List = useMemo(() => {
     return (
       <Stack>
@@ -51,6 +57,7 @@ const History = ({
           isUpdatingDescription={isUpdatingDescription}
           walletID={id}
           items={items}
+          tipBlockNumber={tipBlockNumber}
           dispatch={dispatch}
         />
         <Pagination
@@ -83,6 +90,7 @@ const History = ({
     isUpdatingDescription,
     id,
     items,
+    tipBlockNumber,
     dispatch,
     pageNo,
     totalCount,

packages/neuron-ui/src/components/ImportKeystore/index.tsx

@@ -7,10 +7,17 @@ import { importWalletWithKeystore } from 'states/stateProvider/actionCreators'
 import { StateWithDispatch } from 'states/stateProvider/reducer'
 import { useGoBack } from 'utils/hooks'
 import generateWalletName from 'utils/generateWalletName'
+import { ErrorCode, MAX_WALLET_NAME_LENGTH, MAX_PASSWORD_LENGTH } from 'utils/const'
 
-const defaultFields = {
+interface KeystoreFields {
+  path: string
+  name: string | undefined
+  password: string
+}
+
+const defaultFields: KeystoreFields = {
   path: '',
-  name: '',
+  name: undefined,
   password: '',
 }
 
@@ -25,7 +32,7 @@ const ImportKeystore = (props: React.PropsWithoutRef<StateWithDispatch & RouteCo
   const goBack = useGoBack(history)
 
   useEffect(() => {
-    if (fields.name === '') {
+    if (fields.name === undefined) {
       const name = generateWalletName(wallets, wallets.length + 1, t)
       setFields({
         ...fields,
@@ -60,7 +67,7 @@ const ImportKeystore = (props: React.PropsWithoutRef<StateWithDispatch & RouteCo
 
   const onSubmit = useCallback(() => {
     importWalletWithKeystore({
-      name: fields.name,
+      name: fields.name || '',
       keystorePath: fields.path,
       password: fields.password,
     })(dispatch, history)
@@ -70,6 +77,12 @@ const ImportKeystore = (props: React.PropsWithoutRef<StateWithDispatch & RouteCo
     <Stack verticalFill verticalAlign="center" tokens={{ childrenGap: 15 }}>
       <Stack tokens={{ childrenGap: 15 }}>
         {Object.entries(fields).map(([key, value]) => {
+          let maxLength: number | undefined
+          if (key === 'name') {
+            maxLength = MAX_WALLET_NAME_LENGTH
+          } else if (key === 'password') {
+            maxLength = MAX_PASSWORD_LENGTH
+          }
           return (
             <TextField
               key={key}
@@ -78,14 +91,15 @@ const ImportKeystore = (props: React.PropsWithoutRef<StateWithDispatch & RouteCo
               placeholder={t(`import-keystore.placeholder.${key}`)}
               type={key === 'password' ? 'password' : 'text'}
               readOnly={key === 'path'}
+              maxLength={maxLength}
               value={value}
               validateOnLoad={false}
               onGetErrorMessage={(text?: string) => {
                 if (text === '') {
-                  return t('messages.is-required', { field: t(`import-keystore.label.${key}`) })
+                  return t(`messages.codes.${ErrorCode.FieldRequired}`, { fieldName: `keystore-${key}` })
                 }
                 if (key === 'name' && isNameUsed) {
-                  return t('messages.is-used', { field: t(`import-keystore.label.${key}`) })
+                  return t(`messages.codes.${ErrorCode.FieldUsed}`, { fieldName: `name`, fieldValue: text })
                 }
                 return ''
               }}