feat: skip cells which has data or type when calculate balance - #903
Merged
Conversation
classicalliu
changed the title
![nervos-bot[bot]](https://avatars.githubusercontent.com/in/22976?s=60&v=4){kind=small}
classicalliu
changed the title
nervos-bot
Bot
dismissed
their stale review
August 30, 2019 07:43
Unhold as requested by @classicalliu.
classicalliu
changed the title
classicalliu
changed the title
nervos-bot
Bot
dismissed
their stale review
September 3, 2019 07:53
Unhold as requested by @classicalliu.
Keith-CY
reviewed
Sep 3, 2019
ashchan
reviewed
Sep 4, 2019
|
|
||
| export default class SkipDataAndType { | ||
| private static moduleName = '' | ||
| private static fileName = 'skip-data-and-type.json' |
Contributor
There was a problem hiding this comment.
How about a global settings.json for all related persisted app configuration? I don't see any benefit maintaining a single file for each feature.
Contributor
Author
There was a problem hiding this comment.
Add a BaseSettings to read/update settings and read/update SkipDataAndType via this.
Co-Authored-By: Chen Yu <keithwhisper@gmail.com>
Keith-CY
approved these changes
Sep 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the
balancenot include cells which has data or type, andtotalBalanceincludes.Has a setting to set can use cells with data/type or not.