Skip to content

feat: Load icon for BrowserWindow to show it on linux launcher #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keith-CY merged 1 commit into from
Oct 16, 2019
Merged

feat: Load icon for BrowserWindow to show it on linux launcher #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...ges/neuron-wallet/assets/images/icon.icns → ...ages/neuron-wallet/assets/icons/icon.icns
View file
Open in desktop
File renamed without changes.
0 ...ages/neuron-wallet/assets/images/icon.ico → packages/neuron-wallet/assets/icons/icon.ico
View file
Open in desktop
File renamed without changes.
0 ...ages/neuron-wallet/assets/images/icon.png → packages/neuron-wallet/assets/icons/icon.png
View file
Open in desktop
File renamed without changes
6 changes: 3 additions & 3 deletions packages/neuron-wallet/electron-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ dmg:
win:
verifyUpdateCodeSignature: false
artifactName: "${productName}-v${version}-${os}-${arch}-installer.${ext}"
icon: assets/images/icon.ico
icon: assets/icons/icon.ico
target:
- target: nsis
arch:
Expand All @@ -53,7 +53,7 @@ win:
mac:
artifactName: "${productName}-v${version}-${os}.${ext}"
category: public.app-category.finance
icon: assets/images/icon.icns
icon: assets/icons/icon.icns
hardenedRuntime: true
gatekeeperAssess: false
entitlements: assets/entitlements.plist
Expand All @@ -66,6 +66,6 @@ mac:
linux:
artifactName: "${productName}-v${version}-${os}-${arch}.${ext}"
category: Finance
icon: assets/images/
icon: assets/icons/
target:
- AppImage
1 change: 1 addition & 0 deletions packages/neuron-wallet/src/startup/create-main-window.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ function createWindow() {
minHeight: 600,
show: false,
backgroundColor: '#e9ecef',
icon: path.join(__dirname, '../neuron-ui/icon.png'),
webPreferences: {
devTools: env.isDevMode,
nodeIntegration: env.isDevMode || env.isTestMode,
Expand Down