Skip to content

Fix provider state refresh and taskbar-safe window placement for menu/settings popups - #1

Merged
Finesssee merged 1 commit into
nesszer:mainfrom
isbool:main
Feb 11, 2026
Merged

Fix provider state refresh and taskbar-safe window placement for menu/settings popups#1
Finesssee merged 1 commit into
nesszer:mainfrom
isbool:main

Conversation

@isbool

@isbool isbool commented Feb 10, 2026

Copy link
Copy Markdown
  • With no enabled providers, UI messaging was misleading.
  • Refresh could run before new settings were synced, causing stale refresh behavior.
  • Main popup could open oversized/cropped or in awkward screen positions.
  • Settings window could appear behind/away from the menu instead of opening near it.

Showcase of the issues:
output

What changed

  • Added provider placeholder helper and synchronized provider list on refresh startup.
  • Added explicit empty/fallback UI states:
    • No providers selected.
    • No provider data available.
  • Reordered settings/refresh flow so settings are synced before refresh is triggered.
  • Main popup:
    • Taskbar-safe work-area sizing/positioning.
    • Compact default size (360x500) with monitor clamping.
    • Explicit open/reposition behavior for tray and shortcut paths.
  • Settings window:
    • Positioned adjacent to the main popup (right/left/top/bottom) based on available space.
    • Uses taskbar-safe work area and monitor clamping.
    • Focuses when spawned with new placement.
  • Reverted temporary auth UX experiment (Authenticate...) per request.

Showcase after the changes
output
:

- Fix stale loading/selection behavior when provider enablement changes
- Show explicit empty states when no providers are selected or no data is available
- Ensure settings changes are synced before refresh runs
- Rework main popup sizing/placement to be taskbar-safe and less tall by default
- Place settings window adjacent to the main popup based on available screen space
@Finesssee

Copy link
Copy Markdown
Collaborator

yooo thanks for the first pull request on this project man!

@Finesssee

Copy link
Copy Markdown
Collaborator

I'll merge this PR

@Finesssee
Finesssee merged commit 4f155aa into nesszer:main Feb 11, 2026
@Finesssee

Copy link
Copy Markdown
Collaborator

Thanks for the first PR to this repo, @isbool! Great work on the window placement fixes and provider state sync — the before/after GIFs really showed the improvement. Merged!

@isbool

isbool commented Feb 12, 2026

Copy link
Copy Markdown
Author

@Finesssee thanks for merging! 😄

I’m working on another PR and wanted to ask: should we enforce cargo fmt (rustfmt) in the repo? It’d keep formatting consistent across machines and avoid big style diffs. I ran it once and it touched a lot of unrelated code, so I had to revert most of it to match the current formatting. Happy to follow whatever you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants