Fix provider state refresh and taskbar-safe window placement for menu/settings popups - #1
Merged
Merged
Conversation
- Fix stale loading/selection behavior when provider enablement changes - Show explicit empty states when no providers are selected or no data is available - Ensure settings changes are synced before refresh runs - Rework main popup sizing/placement to be taskbar-safe and less tall by default - Place settings window adjacent to the main popup based on available screen space
Collaborator
|
yooo thanks for the first pull request on this project man! |
Collaborator
|
I'll merge this PR |
Collaborator
|
Thanks for the first PR to this repo, @isbool! Great work on the window placement fixes and provider state sync — the before/after GIFs really showed the improvement. Merged! |
Author
|
@Finesssee thanks for merging! 😄 I’m working on another PR and wanted to ask: should we enforce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showcase of the issues:

What changed
Showcase after the changes

: