Skip to content

Fix tray popup placement for vertical taskbars - #122

Merged
Finesssee merged 3 commits into
mainfrom
finesssee-install-code-review-skill
Jul 3, 2026
Merged

Fix tray popup placement for vertical taskbars#122
Finesssee merged 3 commits into
mainfrom
finesssee-install-code-review-skill

Conversation

@Finesssee

Copy link
Copy Markdown
Collaborator

Fixes #121.

Summary

  • Infer tray fallback anchors from the taskbar side instead of assuming bottom-right.
  • Reuse the same inferred anchor when the frontend re-anchors after resizing.
  • Add left/right vertical taskbar regressions.

Local checks

  • cargo test --manifest-path apps\desktop-tauri\src-tauri\Cargo.toml
  • git diff --check
  • Cua Driver CLI desktop/screen inspection

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Finesssee
Finesssee force-pushed the finesssee-install-code-review-skill branch from 973e8ac to 3d6fe40 Compare July 3, 2026 16:04
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Finesssee

Copy link
Copy Markdown
Collaborator Author

Local built UI verification is done with Cua Driver on Windows 10 using a left-docked taskbar.

Result after the tray-click fix: CodexBar opens at x=132,y=674,width=328,height=327, anchored beside the left taskbar (work_area={X=124,Y=0,Width=1796,Height=1080}), instead of the old bottom-right popout position (x=1492,y=352,width=420,height=680). Restored the taskbar back to bottom after the test.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Finesssee

Copy link
Copy Markdown
Collaborator Author

Thermo-nuclear code quality review complete.

Found one structural cleanup issue before merge: commands/system.rs was reaching into shell::geometry and manually constructing MonitorPlacement, which leaked the shell geometry internals into the command layer. I fixed that in 06643db3 by keeping geometry private again and exposing a shell-level reanchor positioning helper instead.

After that cleanup, I don't see remaining blockers: the taskbar-side inference lives in the canonical shell positioning layer, the resize re-anchor path reuses the same positioning policy, the tray-click route now targets TrayPanel instead of PopOut, and the 1k+ tray_bridge.rs file was already over the threshold before this PR rather than being pushed over by it.

@Finesssee
Finesssee merged commit 00df23d into main Jul 3, 2026
2 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Pop up windows appears at wrong place

1 participant