fix(cli): harden secrets upserts - #1234
Merged
Aaronontheweb merged 1 commit intoMay 30, 2026
Merged
Conversation
Aaronontheweb
force-pushed
the
fix/secrets-upsert-repair
branch
from
May 30, 2026 01:43
709ea66 to
ea7d2db
Compare
Aaronontheweb
added
the
config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
netclaw initoverwrites explicitly entered secret values while preserving unrelated keys.netclaw secretskey paths across.and:delimiters, remove literal colon-key collisions, and supportsecrets addas an alias forset.netclaw secretsrepair commands.Closes #1232
Closes #1233
Validation
dotnet test src/Netclaw.Cli.Tests/Netclaw.Cli.Tests.csproj --filter "FullyQualifiedName~SecretsCommandTests|FullyQualifiedName~WizardConfigBuilderTests|FullyQualifiedName~UpdateCommandTests"dotnet test src/Netclaw.Cli.Tests/Netclaw.Cli.Tests.csprojdotnet slopwatch analyzepwsh ./scripts/Add-FileHeaders.ps1 -Verifygit diff --checkValidation blockers
./evals/run-evals.shcould not start because eval target environment variables are not set in this non-interactive shell../scripts/smoke/run-smoke.sh init-wizardbuilt CLI and daemon binaries, then stopped while trying to install Ollama viasudo; this shell cannot provide a sudo password.