feat: allow deleting providers from provider manager list

[Aaronontheweb]

Adds Delete keybinding to the netclaw provider list so configured providers can be removed without opening Details first.

Changes:

• Show [Delete] Remove in the provider list footer
• Route Delete to a remove confirmation flow for configured rows
• Prevent deleting unconfigured provider type rows with an error message
• Reuse existing model-role guard and dual-file removal logic

Files changed:

• src/Netclaw.Cli/Tui/ProviderManagerPage.cs
• src/Netclaw.Cli/Tui/ProviderManagerViewModel.cs

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/Netclaw.Cli/Tui/ProviderManagerPage.cs:1009

• Clear ErrorMessage before you start the remove flow. The Delete handler can set an error for an unconfigured row. That error stays visible during remove confirmation and shows incorrect status.

            if (item.IsConfigured)
            {
                ViewModel.RemoveSelectedProvider(item);
            }
            else

src/Netclaw.Cli.Tests/Tui/ProviderManagerPageTests.cs:96

• The PR description lists only two changed files. This PR also changes src/Netclaw.Cli.Tests/Tui/ProviderManagerPageTests.cs. Update the PR description file list so it stays accurate.

    [Fact]
    public async Task DeleteKey_OnSecondRow_RemovesHighlightedProvider()
    {

[Copilot]

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/Netclaw.Cli/Tui/ProviderManagerViewModel.cs:749

• Clear ErrorMessage before you enter the remove flow. A stale list error (for example from Delete on an unconfigured row) will hide later StatusMessage updates because the status bar prefers ErrorMessage.

        if (item is not { IsConfigured: true, ConfiguredName: not null })
            return;

        DetailProvider = item;
        StartRemove();

src/Netclaw.Cli.Tests/Tui/ProviderManagerPageTests.cs:126

• This test enqueues navigation keys before the app enters ProviderManagerState.List. It can fail if probing becomes asynchronous in the test probe (or in future refactors). Start the app first, wait for List state, then enqueue keys.

        var (_, app, vm) = CreateHeadlessApp(out var input);

        input.EnqueueKey(ConsoleKey.DownArrow); // move highlight off row 0 -> bravo-ollama
        input.EnqueueKey(ConsoleKey.Delete);    // start remove for highlighted row
        input.EnqueueKey(ConsoleKey.Enter);     // confirm "Yes, remove"

[Copilot]

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/Netclaw.Cli/Tui/ProviderManagerViewModel.cs:741

• The XML doc comment says this method removes a provider. The method only starts the remove-confirmation flow. This can confuse readers and future callers.

    /// <summary>
    /// Remove a configured provider. Used by the Delete keybinding on the list.
    /// Takes the target item directly (resolved from the list's live highlight)
    /// rather than the selection index, which only updates on Enter.
    /// </summary>