fix(tui): support multiple provider instances of the same type - #385
Merged
Conversation
The provider manager TUI used FirstOrDefault per provider type, hiding duplicate instances when two providers shared the same type (e.g., two openai-compatible entries with different endpoints). Rewrite RefreshDisplayProviders to show all configured instances followed by unconfigured type placeholders, and add a "+ Add new provider" option that presents all types for selection. Also enrich the model manager and CLI provider list with display names so users can distinguish provider instances at a glance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #384. The provider manager TUI assumed one instance per provider type, breaking
netclaw providerandnetclaw modelwhen two providers shared the same type (e.g., twoopenai-compatibleentries with different endpoints).RefreshDisplayProviders()— two-pass approach shows all configured instances followed by unconfigured type placeholders, instead ofFirstOrDefaultper typenetclaw provider listnow showName (DisplayName)formatTest plan
dotnet build— full solution compilesDisplayProviders_ShowsMultipleInstancesOfSameTypeStartAddNewProvider_TransitionsToAddSelectTypeGoBack_FromAddSelectType_ReturnsToListRefresh_PopulatesDisplayNameFromRegistryRefresh_FallsBackToTypeWhenNoRegistryopenai-compatibleentries → both appear innetclaw providerTUInetclaw provider listshows DisplayName columnnetclaw modelshowsName (DisplayName)in provider selection