feat(observability): log turn_tool_call_batch as structured metric - #625
Merged
Conversation
Adds a TurnLog().Info call at the point where tool calls are dispatched in HandleToolCallResponse, emitting count and tool names as a single structured log line per assistant response. This enables one-liner grep+awk queries over daemon logs to measure the distribution of tool_calls_per_response — a prerequisite for validating whether vLLM + qwen3_coder parser or provider switches (Anthropic, OpenAI) unlock batched tool calls. Closes #623
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TurnLog().Info("turn_tool_call_batch count={Count} tools={Tools}", ...)inHandleToolCallResponseimmediately before the per-tool-call dispatch loopTurnLog()patterns in the file (same logging adapter, same structured key style)Closes #623
Test plan
dotnet buildpasses with 0 warningsdotnet slopwatch analyzepasses with 0 new violationsgrep turn_tool_call_batchin daemon logs emits one line per tool-invocation round-trip withcountandtoolsfields populated