refactor: remove ppool (#349)

[konard]

Fixes #349

Summary

• Removed the ppool public API surface from PersistMemoryManager, including the manager alias, implementation header, generated single-header output, tests, and benchmarks.
• Updated the live README/docs to stop presenting ppool as a supported persistent type.
• Kept generic typed_guard support for free_all() cleanup and covered it with a local probe type instead of ppool.
• Added test_issue349_remove_ppool as a structural regression guard for the removed header and manager alias.
• Synced repo-guard size-rule policy and the README version badge so the docs/version CI invariants pass after touching README.

Verification

• Confirmed the new test_issue349_remove_ppool failed before the implementation removal because Mgr::ppool<T> still existed.
• cmake --build build --target test_issue349_remove_ppool test_issue235_code_review
• ctest --test-dir build --output-on-failure -R 'test_issue349_remove_ppool|test_issue235_code_review'
• cmake --build build
• ctest --test-dir build --output-on-failure (92/92 passed)
• cmake -B build-bench -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=ON -DPMM_BUILD_EXAMPLES=OFF -DPMM_BUILD_BENCHMARKS=ON
• cmake --build build-bench --target pmm_benchmarks
• bash scripts/generate-single-headers.sh --strip-comments --output-dir /tmp/pmm-generated-check plus diff against committed single_include/pmm/*
• bash scripts/check-docs-consistency.sh
• bash scripts/check-repo-guard-rollout.sh
• bash scripts/check-version-consistency.sh
• GITHUB_BASE_REF=main bash scripts/check-changelog-fragment.sh
• tracked file-size check passed
• ~/.local/bin/clang-format --dry-run --Werror on changed C++ files
• git diff --check

CI

All GitHub checks pass on 710c396, including clang-format, cppcheck, docs consistency, version consistency, repo-guard, single-header freshness, Linux/macOS/Windows builds, demo builds, and sanitizer jobs.

[konard]

Solution summary

Implemented and pushed the fix to PR 350: #350

What changed

• Removed ppool from the public PMM API:
  • deleted include/pmm/ppool.h
  • removed PersistMemoryManager::ppool<T>
  • regenerated single_include/pmm/pmm.h and pmm_no_comments.h
• Removed old ppool tests and benchmark coverage.
• Added test_issue349_remove_ppool to guard that the header and manager alias stay removed.
• Updated live docs/README references so ppool is no longer presented as supported API.
• Kept generic typed_guard free_all() behavior tested with a small local probe type.
• Added a major-bump changelog fragment for the breaking API removal.
• Synced repo-guard size-rule policy and README version badge because CI required those invariants after the README/docs changes.

Verification

• Local targeted tests passed:
  • test_issue235_code_review
  • test_issue349_remove_ppool
• Full local CTest passed: 92/92.
• Optional benchmark target builds with PMM_BUILD_BENCHMARKS=ON.
• Single-header regeneration diff matched committed files.
• Local docs/version/changelog/repo-guard checks passed.
• GitHub Actions are all green on 710c396, including clang-format, cppcheck, docs consistency, version consistency, repo-guard, single-header freshness, Linux/macOS/Windows builds, demo builds, and sanitizer jobs.

Working tree is clean, PR is marked ready for review, and I checked issue/PR comments/reviews after the update; there were no new comments to address.

Next useful step: review and merge PR 350.

---

This summary was automatically extracted from the AI working session output.

[konard]

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

• Model: GPT-5.4
• Provider: OpenAI
• Public pricing estimate: $17.737796

📊 Context and tokens usage:

• 31.1M / 1.1M (2961%) input tokens, 39.4K / 128K (31%) output tokens

Total: (289.6K + 30.8M cached) input tokens, 39.4K output tokens, $17.737796 cost

🤖 Models used:

• Tool: OpenAI Codex
• Requested: gpt-5.4
• Model: GPT-5.4 (gpt-5.4)

📎 Log file uploaded as Repository (53743KB)

• View complete solution draft log

---

Now working session is ended, feel free to review and add any feedback on the solution draft.

[konard]

✅ Ready to merge

This pull request is now ready to be merged:

• All CI checks have passed
• No merge conflicts
• No pending changes

---

Monitored by hive-mind with --auto-restart-until-mergeable flag