refactor!: x/slashing missed block window#1
Merged
pr0n00gler merged 3 commits intoneutronfrom Sep 21, 2023
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // determine if the validator signed the previous block | ||
| previous, err := k.GetMissedBlockBitmapValue(ctx, consAddr, index) | ||
| if err != nil { | ||
| panic(errors.Wrap(err, "failed to get the validator's bitmap value")) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| // Bitmap value has changed from not missed to missed, so we flip the bit | ||
| // and increment the counter. | ||
| if err := k.SetMissedBlockBitmapValue(ctx, consAddr, index, true); err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| // Bitmap value has changed from missed to not missed, so we flip the bit | ||
| // and decrement the counter. | ||
| if err := k.SetMissedBlockBitmapValue(ctx, consAddr, index, false); err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
pr0n00gler
changed the title
…BlockBitmap to keep compatibility for third-party projects
NeverHappened
approved these changes
Aug 18, 2023
NeverHappened
left a comment
NeverHappened
left a comment
There was a problem hiding this comment.
Looks same as original PR, nothing bad found!
sotnikov-s
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of cosmos#15580 to Cosmos SDK 0.47