Skip to content
Prev Previous commit
Next Next commit
MLN-665 | fix: drop unused linter rules
  • Loading branch information
vitalyisaev2 committed Jun 8, 2022
commit ab2c59e97c769a559bd01b0394d874708fe337de
28 changes: 7 additions & 21 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -264,15 +264,13 @@ linters:
enable-all: true
fast: false
disable:
- promlinter # to many bugs
- gci # ucs-fmt противоречит gci (скорее всего)
- godox # мы пока не готовы к этому
- goerr113 # использование errors противоречит этому правилу
- goimports # ucs-fmt противоречит goimports
- gofumpt # ucs-fmt противоречит gofumpt (скорее всего)
- exhaustivestruct # раздувает код
- paralleltest # назначение функции t.Parallel() не до конца понятно
- testpackage # сильно ограничивает возможности проверки в юнит-тестах
- promlinter # too many bugs
- gci # relation with goimports is not clear
- gofumpt # conflicts with wsl
- godox # useless
- exhaustivestruct # bloats code
- paralleltest # it's not clear when and how to use t.Parallel()
- testpackage # seriously limits testing capabilities

issues:
# List of regexps of issue texts to exclude, empty list by default.
Expand All @@ -299,12 +297,6 @@ issues:
- gomnd
- gocognit

- path: "perf/app"
linters:
- gochecknoglobals
- gochecknoinits
- dupl

- path: mock.go
text: "exported type"
linters:
Expand All @@ -330,12 +322,6 @@ issues:
- path: config.go
text: "fieldalignment"

- path: server/config
text: "fieldalignment"

- path: _test\.go
text: "fieldalignment"

# Independently from option `exclude` we use default exclude patterns,
# it can be disabled by this option. To list all
# excluded by default patterns execute `golangci-lint run --help`.
Expand Down
6 changes: 3 additions & 3 deletions utils/application_terminator.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ import (
"github.com/go-logr/logr"
)

// ApplicationTerminator - interface to shut down the application by MemLimiter command.
// It is used in such cases when it's better to restart the application rather than continue working.
// ApplicationTerminator shuts down the application by MemLimiter command.
// It is used in the cases when it's better to restart the application rather than continue working.
// It must be implemented by library users, because every application has its own
// termination protocol.
// graceful termination protocol.
type ApplicationTerminator interface {
// Terminate is a special method registering the fatal error of memory management.
// It's mandatory for the application to terminate itself within or after this call.
Expand Down