MLN-666 | refactor: more small plots

newcloudtechnologies · vitalyisaev2 · Jun 14, 2022 · Jun 9, 2022 · Jun 9, 2022 · Jun 9, 2022
commit 0744843216f6314109603e482a4dcdac5d1d1a68
diff --git a/README.md b/README.md
@@ -85,6 +85,8 @@ There are several key settings in MemLimiter [configuration](controller/nextgc/c
 * `RSSLimit`
 * `DangerZoneGC` 
 * `DangerZoneThrottling` 
+* `Period`
+* `WindowSize`
 * `Coefficient` ($K_{p}$)
 
 You have to pick them empirically for your service. The settings must correspond to the business logic features of a particular service and to the workload expected.
@@ -95,7 +97,9 @@ Settings ranges:
 * $RSS_{limit} == {1G}$
 * $DangerZoneGC == 50%$
 * $DangerZoneThrottling == 90%$
-* $K_{p} \in {0, 1, 5, 10, 50, 100}$
+* $Period == 100ms$
+* $WindowSize == 20$
+* $K_{p} \in \{0, 1, 5, 10, 50, 100\}$
 
 These plots may give you some inspiration on how $K_{p}$ value affects the physical memory consumption other things being equal:
 
@@ -108,7 +112,7 @@ These plots may give you some inspiration on how $K_{p}$ value affects the physi
 
 And the summary plot with RSS consumption depending on $K_{p}$ value:
 
-![RSS](docs/rss_pivot.png)
+![RSS](docs/rss.png)
 
 The general conclusion is that:
 * Disabling MemLimiter causes OOM;

diff --git a/docs/k_p/05.png b/docs/k_p/05.png
diff --git a/docs/k_p/1.png b/docs/k_p/1.png
diff --git a/docs/k_p/10.png b/docs/k_p/10.png
diff --git a/docs/k_p/5.png b/docs/k_p/5.png
diff --git a/docs/k_p/50.png b/docs/k_p/50.png
diff --git a/docs/k_p/disabled.png b/docs/k_p/disabled.png
diff --git a/docs/rss.png b/docs/rss.png
diff --git a/docs/rss_pivot.png b/docs/rss_pivot.png
diff --git a/test/allocator/analyze/render.py b/test/allocator/analyze/render.py
@@ -21,7 +21,7 @@ def bytes_major_formatter(x, pos):
 def single_report(report: Report):
     df = report.df
 
-    fig, ax = plt.subplots(figsize=(8, 6))
+    fig, ax = plt.subplots(figsize=(6, 4.5))
     ax.set_xlim(0, 60)
 
     ax.set_xlabel('Time, seconds')