3단계 - @Configuration 설정 - 리뷰 요청#149
Merged
gwonsungjun merged 11 commits intonext-step:headf1rstfrom Sep 23, 2022
Merged
Conversation
gwonsungjun
approved these changes
Sep 23, 2022
gwonsungjun
left a comment
gwonsungjun
left a comment
There was a problem hiding this comment.
안녕하세요.
3단계 미션 구현 잘 해주셨네요!
크게 피드백 드릴건 없구요. 애플리케이션 정상 구동과 깨지는 테스트 코드들 한번 더 점검해서 다음 단계 리뷰 요청 주시면 좋을 것 같아요.
고생하셨습니다 🙇♂️
|
|
||
| void initialize(); | ||
|
|
||
| Collection<Object> controllers(); |
There was a problem hiding this comment.
메소드명에 get을 일부러 빼신걸까요? 일부러 그러셨다면 의도가 궁금하네요 :)
아니라면 메서드명은 동사로 리팩토링 해보면 어떨까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요 성준님!
이번 단계 개인적으로 너무 어려웠던것 같습니다.. 😭
아직 미흡한 부분이 많지만 리뷰 요청 간격이 너무 벌어지는것 같아 피드백을 먼저 부탁드리고자 합니다.
이번 리뷰도 잘 부탁드립니다