Merged
Conversation
yongdae
suggested changes
Aug 12, 2022
yongdae
left a comment
yongdae
left a comment
There was a problem hiding this comment.
세션 구하기 미션을 잘 수행해주셨네요. 💯
소소하지만 몇 가지 의견을 남겨놓았습니다.
확인하시고 다시 리뷰 요청 부탁드릴꼐요. 🔥
| @@ -0,0 +1,9 @@ | |||
| package mvc.view; | |||
|
|
|||
| public class StaticViewResolver implements ViewResolver { | |||
| import java.util.Collections; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
| import java.io.IOException; | ||
| import java.net.URISyntaxException; | ||
|
|
||
| public class SessionInterceptor implements Interceptor { |
There was a problem hiding this comment.
Interceptor 개념을 사용해서 Session을 처리해주셨네요. 👍
yongdae
approved these changes
Aug 15, 2022
Comment on lines
+43
to
+45
| executeInterceptorsPreHandle(request, response); | ||
| controller.service(request, response); | ||
| response.writeResponse(); | ||
| response.writeResponse(dos); |
There was a problem hiding this comment.
Interceptor과 Controller에 대한 처리가 분리되어서
이전보다 처리 방식을 이해하기 쉬운 코드가 된 것 같아요. 👍
| requestBody.addAttribute(name, value); | ||
| } | ||
|
|
||
| public Map<String, Object> getBodyAttributes() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님!
4단계 요구사항인 세션을 구현해보았습니다.
또한 저번 피드백을 반영해서 화면 구성에 대한 책임을
View객체에 위임해 봤습니다.다양한 의견 주시면 감사하겠습니다!