Toast should have cursor pointer if `onClick`

[skjnldsv]

• Have proper css cursor
• onClick should probably not be an empty function by default but undefined. That way we can properly detect and apply a class

[ChristophWurst]

onClick should probably not be an empty function by default

It is. We just set one here https://github.com/nextcloud/nextcloud-dialogs/blob/687e368ee49c17787d108c5b6be9ab7f42e4512f/lib/toast.ts#L63. We could assign the completed options to a new variable and check for undefined at https://github.com/nextcloud/nextcloud-dialogs/blob/687e368ee49c17787d108c5b6be9ab7f42e4512f/lib/toast.ts#L85 with a custom class.

[skjnldsv]

Yep, I'm on it.

onClick should probably not be an empty function by default

It is. We just set one here

https://github.com/nextcloud/nextcloud-dialogs/blob/687e368ee49c17787d108c5b6be9ab7f42e4512f/lib/toast.ts#L63

Yes, that's my complain, having it as an empty function prevent us from detecting if the argument is provided :)
The original Toasitfy lib is using undefined

[ChristophWurst]

So we could just remove our default?

[skjnldsv]

Yes

[skjnldsv]

Shall we open a pr with just d57f864 ?

[ChristophWurst]

Fine by me

[skjnldsv]

Fixed with undo pr #106