fix(ConflictPicker): Allow to set recursive upload note + fix types for conflict utils functions #1176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or conflict utils functions Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/conflict-picker
branch
from
c67ba2a to
c235aca
Compare
artonge
approved these changes
Apr 29, 2024
| export type ConflictResolutionResult = { | ||
| selected: (File|FileSystemEntry|Node)[], | ||
| renamed: (File|FileSystemEntry|Node)[], | ||
| export type ConflictResolutionResult<T extends File|FileSystemEntry|Node> = { |
Contributor
There was a problem hiding this comment.
Maybe we should create a type out of those to ease its use?
Contributor
Author
There was a problem hiding this comment.
I think this makes sense, but I need generics here to allow returning the same as the input.
E.g. if you put in an array of File you also get back an array of File and not Array<File|Node|FileSystemEntry>.
So this prevents casting it every time you use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.